CODEWITHSUNDEEP
pythonxmlunicodelxml
David542
David542

Reputation: 110219

ValueError on writing lxml text

I have the following block to write an xml tag. Sometimes the name is already in the correct form (that is, it won't error), and sometimes it is not

if 'Name' in title_data:
    name = etree.SubElement(info, 'Name')
    try:
        name.text = title_data['Name']
    except ValueError:
        name.text = title_data['Name'].decode('utf-8')

Is there a way to simplify this? For example, something along the lines of:

name.text = title_data['Name'] if (**something**) else title_data['Name'].decode('utf-8')

Upvotes: 0

Views: 32

Answers (1)

kindall
kindall

Reputation: 184201

I assume that you want to avoid having to write similar code for every element you want to set. This has the smell of trying to treat the symptom rather than the cause, but if nothing else, you can simply break that out into a helper function:

def assign_text(field, text):
    try:
        field.text = text
    except ValueError:
        field.text = text.decode("utf-8")

# ...
if "Name" in title_data:
    name = etree.SubElement(info, "Name")
    assign_text(name, title_data["Name"] or None)

Upvotes: 1

Related Questions