CODEWITHSUNDEEP
c#sql
begginer
begginer

Reputation: 11

"ExecuteReader:Connection Property has not been initialized."

private void btnSave_Click(object sender, EventArgs e)
{
    try
    {
        con = new SqlConnection("Data Source = LENOVO; Initial Catalog = MainData; Integrated Security = True");
        con.Open();

        string CheckID = "select StaffID from PersonsData where StaffID='" + txtStaffID.Text + "'";
        cm = new SqlCommand(CheckID);

        SqlDataReader rdr = null;

        rdr = cm.ExecuteReader();

        if (rdr.Read())
        {
            MessageBox.Show("Company Name Already Exists", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
            txtStaffID.Text = "";
            txtStaffID.Focus();
        }
        else
        {
            byte[] img = null;
            FileStream fs = new FileStream(imgLoc, FileMode.Open, FileAccess.Read);
            BinaryReader br = new BinaryReader(fs);
            img = br.ReadBytes((int)fs.Length);
            string Query = "insert into PersonsData (StaffID, FullName, Email, Address, Picture) values('" + this.txtStaffID.Text + "','" + this.txtFullname.Text + "','" + this.txtEmail.Text + "','" + this.txtAddress.Text + "',@img)";
                    if (con.State != ConnectionState.Open)
                        con.Open();
                    cm = new SqlCommand(Query, con);
                    cm.Parameters.Add(new SqlParameter("@img", img));
                    int x = cm.ExecuteNonQuery();
                    con.Close();
                    MessageBox.Show(x.ToString() + "Successfully Saved!");
                }
            }

            catch (Exception ex)
            {
                con.Close();
                MessageBox.Show(ex.Message);
            }

        }

This is my code i don't understand why I'm getting this error:

ExecuteReader:Connection Property has not been initialized.

I'm making a save button where the Staffid will be checked first if already.

Upvotes: 1

Views: 2684

Answers (4)

Sebi
Sebi

Reputation: 3979

Make sure that you assign the SqlConnection to your Command-Object. You can do this via Constructor or Property:

con = new SqlConnection(//Your Connectionstring)
//assign via Constructor
cm = new SqlCommand(CheckID, con);
//or via Property
cm.Connection = con;
SqlDataReader rdr = null;
rdr = cm.ExecuteReader();

Further I would recommend you to use a using-block to make sure that the Command and Connection gets destroyed after using it.

using (var con = new SqlConnection())
{
   using (var cm = new SqlCommand())
   {
   }
}

Upvotes: 0

Nafisul Islam Nazmi
Nafisul Islam Nazmi

Reputation: 41

Before executing the command, you need to say which connection is to be used. In your case, it is:

cm.Connection = con;

Take a note that, include this line of code after opening the connection and after creating the instance of SqlCommand.

Upvotes: 3

sujith karivelil
sujith karivelil

Reputation: 29026

The error message is clear enough, You have to assign the connection for the Command, either through assignement or through the constructor, That is: 

cm = new SqlCommand(CheckID);
cm.Connection = con; // Should be added
SqlDataReader  rdr = cm.ExecuteReader();

Or else you can use the constructor to initialize the command like this:

cm = new SqlCommand(CheckID,con);

Hope that you are aware of these things since you ware used it correctly in the else part of the given snippet

Upvotes: 0

Akshey Bhat
Akshey Bhat

Reputation: 8545

    con = new SqlConnection("Data Source = LENOVO; Initial Catalog = MainData; Integrated Security = True");
    con.Open();
    string CheckID = "select StaffID from PersonsData where StaffID='" + txtStaffID.Text + "'";
    cm = new SqlCommand(CheckID);
    cm.Connection = con; //Assign connection to command

You didn't assign connection to SqlCommand used in the reader

Upvotes: 2

Related Questions