CODEWITHSUNDEEP
phplaraveleloquent
Josh Mountain
Josh Mountain

Reputation: 1950

Eloquent Observer not firing

I have two models, Show and Episode, with a one to many relationship. I have an Observer for each model to watch when they are deleted and do some tasks. If my ShowObserver looks like this everything works properly and cascades down, the EpisodeObserver fires its deleting() method for each Episode that is deleted along with the show:

<?php

/**
 * Listen to the Show deleting event.
 *
 * @param  Show  $show
 * @return void
 */
public function deleting(Show $show)
{
    if ($show->isForceDeleting()) {
        foreach ($show->episodes()->onlyTrashed()->get() as $episode) {
            $episode->forceDelete();
        }
    } else {
        $show->episodes()->delete();
    }
}

However, if I change it to looks like this the EpisodeObserver@deleting() methods never fire even though the Episodes do get forceDeleted:

<?php

/**
 * Listen to the Show deleting event.
 *
 * @param  Show  $show
 * @return void
 */
public function deleting(Show $show)
{
    if ($show->isForceDeleting()) {
        $show->episodes()->onlyTrashed()->forceDelete();
    } else {
        $show->episodes()->delete();
    }
}

Is there something about $show->episodes()->onlyTrashed()->forceDelete(); that is incorrect, or is this potentially a bug?

Upvotes: 2

Views: 1199

Answers (1)

Lionel Chan
Lionel Chan

Reputation: 8059

Check out the documentation (on the red warning block): https://laravel.com/docs/5.3/eloquent#deleting-models

When executing a mass delete statement via Eloquent, the deleting and deleted model events will not be fired for the deleted models. This is because the models are never actually retrieved when executing the delete statement.

This is also same to update call.

So if you need to fire the events, you have no choice but to delete it one by one, or fire your own custom event if performance is critical.

Upvotes: 3

Related Questions