CODEWITHSUNDEEP
c#entity-framework
Gavin5511
Gavin5511

Reputation: 791

Entity Framework One-to-Many AND a One-To-One relationship

I currently have a data model where a property can have multiple property images:

public class Property
{
    public int ID { get; set; }
    public string Name { get; set; }
    public Guid PrimaryImageID { get; set; }

    public ICollection<PropertyImage> Images { get; set; }
}

public class PropertyImage
{
    [Key]
    public Guid ID { get; set; }
    public int PropertyID { get; set; }

    public virtual Property Property { get; set; }
}

However, as you can see, i also want to enable a relationship so that a property can have ONE of those images assigned as a primary image.

I found an article here, that seems to use the Fluent API to configure it, but that's all fairly new to me, so i was wondering if it was possible to do this purely using Entity Framework?

What i REALLY want to achieve, is so that i can just call...

property.primaryimage.url

for example. If a user then wanted to change the primage image of a property, then i just change the PrimaryImageId field to the Guid of a different image

Many thanks

Upvotes: 0

Views: 133

Answers (4)

Steve Padmore
Steve Padmore

Reputation: 1740

If you need a Property to have a primary PropertyImage that can only be an image that is applicable to that Property, the emphasis needs to be switched:

You cannot set the primary Image for a Property until the images are entered and related to the Property to begin with.

You can't add the images unless the Property exists to relate to.

So, you would need to have the PrimaryImage property nullable until later set.

While a PropertyImage relies on a Property, a Property does not rely on a PropertyImage, and so should not be a foreign key in it's record.

This means that the flag (boolean value) for PrimaryImage needs to be stored with the PropertyImage indicating which one of the images is the primary one.

Remove the PrimaryImageId from Property and place a property on the PropertyImage (IsPrimaryImage) to allow selection of the primary one.

You can handle the unique selection either via the UI or more properly with a Unique Constraint on the table.

public class Property
{
    public int ID { get; set; }
    public string Name { get; set; }

    public ICollection<PropertyImage> Images { get; set; }
}

public class PropertyImage
{
    [Key]
    public Guid ID { get; set; }
    public int PropertyID { get; set; }
    public bool IsPrimaryImage { get;set; }

    public virtual Property Property { get; set; }
}

It isn't good practice to try to structure the data and its relationships around the way you'd like to call a method in code.

You can still call the method the way you want and encapsulate any logic you may need inside.

Think along the lines of if there was a cascade delete applicable here to remove items that no longer have a parent item to relate to:

If you delete a Property, all related PropertyImages would be removed too - correctly so because they relied on that record existing.

If you delete the primary PropertyImage, then the Property would have to be deleted because the record it relates to no longer exists...

So to have your method call the way you would like, do something similar to this:

private void UpdatePrimaryImage(PropertyImage oldImage, PropertyImage newImage)
{
    // Pass in the original primary PropertyImage and the new one obtained from the UI.

    // Check that we do not have the same image, otherwise no change needs to be made:
    if(oldImage.IsPrimary != newImage.IsPrimary)
    {
        oldImage.IsPrimary = false;
        newImage.IsPrimary = true;
        Update(oldImage);
        Update(newImage);
        SaveChanges;
    }
}

And to retrieve the current primary image:

Property.PropertyImages.Where(p => p.IsPrimaryImage).Url

Upvotes: 1

Mari Faleiros
Mari Faleiros

Reputation: 738

First, you will add a "PrimaryImage" property to your Property class:

public class Property
{
    public int ID { get; set; }
    public string Name { get; set; }
    public Guid PrimaryImageID { get; set; }
    public virtual PropertyImage PrimaryImage { get; set; }

    public ICollection<PropertyImage> Images { get; set; }
}

In your class where you inherit Entity's framwork DbContext, you can override the method OnModelCreating, which will lead you to:

protected override OnModelCreating(DbModelBuilder modelBuilder)
{
    base.OnModelCreating(modelBuilder);
}

Then, after the line base.OnModelCreating(modelBuilder), you can write:

modelBuilder.Entity<Property>().
    .HasRequired(x => x.PrimaryImage)
    .WithRequiredPrincipal();

modelBuilder.Entity<Property>().
    .HasMany(x => x.Images)
    .WithRequired(x => x.Property);

If this is what you want, then I believe this code allows you to have this property you need. Hope it helps!

Upvotes: 1

SirBirne
SirBirne

Reputation: 297

Try this:

public class Property
{
  public int ID { get; set; }
  public string Name { get; set; }
  public Guid PrimaryImageID { get; set; }
  [ForeignKey("PrimaryImageID")]
  public virtual PropertyImage PrimaryImage { get; set; }

  public ICollection<PropertyImage> Images { get; set; }
}

public class PropertyImage
{
  [Key]
  public Guid ID { get; set; }
  public int PropertyID { get; set; }

  [ForeignKey("PropertyID")]
  public virtual Property Property { get; set; }
}

Upvotes: 0

Ian Murray
Ian Murray

Reputation: 339

Personally, I wouldn't be messing around with EF to do this, the answer in the link you shared would pretty much agree with me. I would simply add another field to the PropertyImage class

public bool IsPrimaryImage {get;set;}

and just find the image based on the value set in that.

Sometimes the simplest solution is the best. You could end up with a convoluted solution in EF that does what you want but at the end of the day, would it really be better than just assigning true or false to a field?

Upvotes: 3

Related Questions