CODEWITHSUNDEEP
androidandroid-volley
uylmz
uylmz

Reputation: 1552

Android volley response listener is not called after request retry

Volley
        .newRequestQueue(context)
        .add(new JsonObjectRequest(
                Request.Method.POST,
                BuildConfig.API_URL + "/user",
                userJson,
                new Response.Listener<JSONObject>() {
                    @Override
                    public void onResponse(JSONObject response) {
                        doSthOnRequestSuccess();
                    }
                },
                new Response.ErrorListener() {
                    @Override
                    public void onErrorResponse(VolleyError error) {
                        doSthOnRequestFail();
                    }
                }));

When a request times out, ErrorListener is run, then later Volley automatically retries the request and this time it is successful. But then the success response listener is not run.

For example, I make a request when user clicks some button, request fails, so I show an error message on screen that the operation has failed. Screen is in error state now, but Volley retries the request in the background, it succeeds, but does not call the success listener code. This results in screen remaining in error state, or user clicking the button again and making a duplicate request.

I modified the api which volley calls to be able to handle duplicate requests, but is there a way to solve this on the android side?

Upvotes: 0

Views: 1202

Answers (2)

kalin
kalin

Reputation: 3576

Volley returns either Error or Success per request. This means that when your onErrorResponse is called you must not expect that onResponse can be ever called.

What happens most probably is that your request with the retries failed. However the server might have processed and sent the last request form your Volley client but the data couldn't reach it on time.

In more detail:

Calls are looped in BasicNetwork class until success or exception. On particular exceptions attemptRetryOnException is called where the RetryPolicy of the request is advised whether to pass the exception or ignore it and try again. Normally this is the DefaultRetryPolicy. From that you can see that you will receive just one final callback from Volley.

However one way to monitor those retries is to enable marker logs by:

<android-sdk>/platform-tools/adb shell setprop log.tag.Volley VERBOSE

Upvotes: 1

nullvoid
nullvoid

Reputation: 131

I think if volley gives you callback after the last try. That means if you have set maximum retries of 3 and api fails for 2 and not for 3 then you will on get the onResponse() callback.

Upvotes: 2

Related Questions