CODEWITHSUNDEEP
c#asp.netasp.net-mvcasp.net-mvc-2enums
ilkin
ilkin

Reputation: 2932

MVC 2 - Passing enum to CheckBoxFor

Let's assume we have a model: 

public class Document
{
    public string Name { get; set;}
    public List<DayOfWeek> WeekDays { get; set; }
}

Is it possible to render checkboxes that represent days of week for that model? I've searched the internet but did not find any solution.

I mean it works whith CheckBoxFor(model=> model.SomeProperty) but it does not work if SomeProperty is List<DayOfWeek>. DayOfWeek here is an enumeration.

Thanks in advance.

Upvotes: 8

Views: 14821

Answers (5)

Jacek
Jacek

Reputation: 1088

Based on Dan Atkinson's (great) answer, I'd made a little bit of shortcuts here and there. My suggestion would be:

The same enum with [Flags] and model.

For View, I wouldn't change type to int but keep checkbox values as string:

<input type="checkbox" name="WeekDays[]" 
       value="<%= dayOfWeek %>" 
       <%= Model.WeekDays.HasFlag(dayOfWeek) ? "checked='checked'" : "" %>" />

Which makes the Controller much simpler:

[HttpPost]
public ActionResult MyPostedPage(MyModel model)
{
    string days = Request.Form.get("WeekDays[]");
    if (days == null) {
        model.WeekDays = 0;  // Depending whether you allow neither day to be selected
                             // you can handle this differently
    } else {
        model.WeekDays = (WeekDays)Enum.Parse(typeof(WeekDays), days);
    }

    ...
 }

Note, the code does not use extensions at all.

Cheers,

Upvotes: 2

Profex
Profex

Reputation: 1390

Note: I had an issue implementing Dan's answer using HasFlag() in the view when using dayOfWeek declared as a var. I had to declare it as the DayOfWeek Enum.

View:

<% foreach(DayOfWeek dayOfWeek in Enum.GetValues(typeof(DayOfWeek))) { %>
  <label>
    <!-- The HasFlag stuff is optional and is just there to show how it would be populated if you're doing a `GET` request. -->
    <input type="checkbox" name="WeekDays[]" value="<%= (int)dayOfWeek%>" <%= Model.WeekDays.HasFlag(dayOfWeek) ? "checked='checked'" : "" %>" />
    <%= dayOfWeek %>
  </label>
<% } %>

I also had and issue with the ToIEnumerable function in helper as there is no function with that name (at least for me).

Upvotes: 1

Dan Atkinson
Dan Atkinson

Reputation: 11699

This would require a change to your DayOfWeek enum, but I favour doing it as a flag (less messy, only one value, etc). Interestingly enough, Microsoft also use days of the week in their enum flags documentation.

DayOfWeek enum using bit flags:

[Flags]//<-- Note the Flags attribute
public enum DayOfWeek
{
  Monday = 1,
  Tuesday = 2,
  Wednesday = 4,
  Thursday = 8,
  Friday = 16,
  Saturday = 32,
  Sunday = 64,
}

Model:

public class Document
{
  public string Name { get; set;}

  //Note that WeekDays is no longer a collection.
  public DayOfWeek WeekDays { get; set; }
}

View:

<% foreach(DayOfWeek dayOfWeek in Enum.GetValues(typeof(DayOfWeek))) { %>
  <label>
    <!-- The HasFlag stuff is optional and is just there to show how it would be populated if you're doing a `GET` request. -->
    <input type="checkbox" name="WeekDays[]" value="<%= (int)dayOfWeek%>" <%= Model.WeekDays.HasFlag(dayOfWeek) ? "checked='checked'" : "" %>" />
    <%= dayOfWeek %>
  </label>
<% } %>

Controller:

[HttpPost]
public ActionResult MyPostedPage(MyModel model)
{
  //I moved the logic for setting this into a helper because this could be re-used elsewhere.
  model.WeekDays = Enum<DayOfWeek>.ParseToEnumFlag(Request.Form, "WeekDays[]");
  ...
}

Quick helper for ParseToEnumFlag:

public static class Enum<T>
{
  public static T ParseToEnumFlag(NameValueCollection source, string formKey)
  {
    //MVC 'helpfully' parses the checkbox into a comma-delimited list. We pull that out and sum the values after parsing it back into the enum.
    return (T)Enum.ToObject(typeof(T), source.Get(formKey).ToIEnumerable<int>(',').Sum());
  }
}

Background: The reason the enum flags values are in a geometric series (1,2,4,8...) is so that, when the values are added together, there is only one possible combination. For example, we would know that 31 could only be Mon, Tue, Wed, Thur and Fri (1 + 2 + 4 + 8 + 16).

Update - 3rd September 2012

It seems I missed out the ToIEnumerable() which is an extension in our source code. It takes a delimited string and casts it into an IEnumerable so is perfect for comma delimited numbers. Thanks to @escist for the headsup.

public static IEnumerable<T> ToIEnumerable<T>(this string source, char delimiter)
{
  return source.Split(new char[] { delimiter }, StringSplitOptions.RemoveEmptyEntries).Select(x => (T)Convert.ChangeType(x, typeof(T)));
}

Upvotes: 19

John Farrell
John Farrell

Reputation: 24754

You could by creating your own custom template which knows how to take the enum list and transform it into checkboxes. Then you'd have to adjust the model binder to handle binding the enum based on the checked value. Since your question lacks details I'm not sure what the use case for this model is.

This is how you'd inline it in your view:

<% foreach(var dayOfWeek in Model.WeekDays) { %>
    <%= dayOfWeek.ToString() %><%= Html.CheckBox(dayOfWeek.ToString()) %>
<% } %>

Upvotes: 1

bmancini
bmancini

Reputation: 2028

You can enumerate on the values of the enum and manually create the checkboxes. Using the same name for each checkbox will submit them as an array in the ActionMethod.

<% foreach(var value in Enum.GetValues(typeof(DayOfWeek))) { %>
     <% var name = Enum.GetName(typeof(DayOfWeek), value); %>
     <label for="dayofweek<%=value %>"><%=name %></label>
     <input type="checkbox" id="dayofweek<%=value %>" name="dayofweek" value="<%=value %>" />
<% } %>

Your action method would be something like:

public ActionResult Save(DayOfWeek[] dayofweek)
{
     // Do Stuff
}

Upvotes: 13

Related Questions