CODEWITHSUNDEEP
azure-devops
GaTechThomas
GaTechThomas

Reputation: 6076

VSTS rejected pull request completion workflow

We have VSTS pull requests (PR's) set up to require 2 reviewers before the request can complete.

This scenario happened today:

  1. Pull request created with 2 reviewers
  2. One reviewer accepted the PR and the other reviewer rejected
  3. The author fixed and pushed up the code
  4. The reviewer who had rejected the code approved
  5. The PR completed successfully without the first approver seeing the update

We need the original approvals and rejections to be reset when the updated code comes in. Is this possible out of the box?

Upvotes: 3

Views: 1376

Answers (2)

Tim Goodman
Tim Goodman

Reputation: 23976

The option you want now exists. (I believe it was added sometime after you posted the question.) Under the branch policies, check the box labeled "Reset code reviewer votes when there are new changes." See documentation here

So far as I know this resets all votes, regardless of whether they were acceptances or rejections. So in cases where an optional reviewer rejected the previous version, there's a bit of a risk that someone might then complete the pull request before that reviewer verifies that their reason for rejection was adequately addressed.

Upvotes: 1

starian chen-MSFT
starian chen-MSFT

Reputation: 33698

There isn’t the feature of resetting feedback (approve and reject) when code updated.

The workaround of your requirement is that you can require specific reviewers to review code.

  1. Go do team project admin page (settings) > Version Control >Select a branch of a repository
  2. Click Add a new path in code review requirements

enter image description here

After that, that user just review code of pull request after others have reviewed the code (all approve).

I submit a user voice here that you can vote. Pull request: rest feedback of related active pull request after code changes (push new changes)

Upvotes: 0

Related Questions