CODEWITHSUNDEEP
javaswingtimejspinner
Hristo Valchev Hristov
Hristo Valchev Hristov

Reputation: 227

JSpinner showing time has constant hours offset despite correct value

I have the following piece of code that is supposed to show time in JSpinner object

Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("GMT"));

cal.set(Calendar.HOUR_OF_DAY, 0);
cal.set(Calendar.AM_PM, 0);
cal.set(Calendar.HOUR, 0);
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);

spStartTime = new JSpinner(new CustomSpinnerModel(cal.getTime(), null, null, cal.get(Calendar.HOUR_OF_DAY), 100, "start"));

((JSpinner.DefaultEditor) spStartTime.getEditor()).getTextField().setFormatterFactory(new DefaultFormatterFactory(new DateFormatter(new SimpleDateFormat("hh:mm:ss,SSS"))));

CustomSpinnerModel extends SpinnerDateModel and I am overriding getNextValue() and getPreviousValue().

public Object getNextValue()
{
    Object next = super.getValue();
    Calendar calendar = new GregorianCalendar();

    calendar.setTimeZone(TimeZone.getTimeZone("GMT"));
    calendar.setTime((Date) next);

    Date helper = new Date(calendar.getTimeInMillis() + defaultStep);

    calendar.setTime(helper);

    System.out.println(calendar.getTimeInMillis());
    return calendar.getTime();
}

Now this prints 100 milliseconds the first time I hit the UP arrow, meaning the value is correct as I am starting with 0 milliseconds. The problem is that what I see in the JSpinner is 

02:00:00,100

There is a constant 2 hours offset in the visualization.

Upvotes: 1

Views: 73

Answers (1)

aterai
aterai

Reputation: 9808

I think DateFormat#setTimeZone(TimeZone) is what you are looking for:

//((JSpinner.DefaultEditor) spStartTime.getEditor()).getTextField()
//  .setFormatterFactory(new DefaultFormatterFactory(
//    new DateFormatter(new SimpleDateFormat("hh:mm:ss,SSS"))));
SimpleDateFormat format = new SimpleDateFormat("HH:mm:ss,SSS");
format.setTimeZone(TimeZone.getTimeZone("GMT"));
((JSpinner.DefaultEditor) spStartTime.getEditor()).getTextField()
    .setFormatterFactory(new DefaultFormatterFactory(
      new DateFormatter(format)));

import java.awt.*;
import java.text.*;
import java.util.*;
import javax.swing.*;
import javax.swing.text.*;

public class DateEditorTimeZoneTest {
  public JComponent makeUI() {
    SimpleDateFormat format = new SimpleDateFormat("HH:mm:ss,SSS");
    format.setTimeZone(TimeZone.getTimeZone("GMT"));

    Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("GMT"));
    cal.clear(Calendar.HOUR_OF_DAY);
    cal.clear(Calendar.AM_PM);
    cal.clear(Calendar.HOUR);
    cal.clear(Calendar.MINUTE);
    cal.clear(Calendar.SECOND);
    cal.clear(Calendar.MILLISECOND);

    Date start = cal.getTime();
    System.out.println(start);
    System.out.println(format.format(start));

    int defaultStep = 100;
    JSpinner spinner = new JSpinner(new SpinnerDateModel(
            start, null, null, Calendar.MILLISECOND) {
      @Override public void setCalendarField(int calendarField) {
        // If you only want one field to spin you can subclass
        // and ignore the setCalendarField calls. 
      }
      @Override public Object getNextValue() {
        Object next = super.getValue();
        Calendar calendar = new GregorianCalendar();
        calendar.setTimeZone(TimeZone.getTimeZone("GMT"));
        calendar.setTime((Date) next);
        Date helper = new Date(calendar.getTimeInMillis() + defaultStep);
        calendar.setTime(helper);
        System.out.println(calendar.getTimeInMillis());
        return calendar.getTime();
      }
      //@Override public Object getPreviousValue() {
      //  //...
      //}
    });
    JSpinner.DateEditor editor = new JSpinner.DateEditor(spinner, "HH:mm:ss,SSS");
    spinner.setEditor(editor);
    editor.getTextField().setFormatterFactory(
        new DefaultFormatterFactory(new DateFormatter(format)));

    JPanel p = new JPanel();
    p.add(spinner);
    return p;
  }
  public static void main(String... args) {
    EventQueue.invokeLater(() -> {
      JFrame f = new JFrame();
      f.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
      f.getContentPane().add(new DateEditorTimeZoneTest().makeUI());
      f.setSize(320, 240);
      f.setLocationRelativeTo(null);
      f.setVisible(true);
    });
  }
}

Upvotes: 1

Related Questions