CODEWITHSUNDEEP
phplaravelvalidationlaravel-5.4validationrules
kesm0
kesm0

Reputation: 875

Validation rules required_if with other condition (Laravel 5.4)

I got a problem with validation rules with nested conditions.

class StoreRequest extends Request
{
        public function authorize(){
        return true;
        }

        public function rules(){
                return [
                    'type_id'     => 'required|integer',
                    'external_id' => 'required_if:type_id,==,3|integer',
                ];
        }
}

Indeed I want to : - check the external_id only if the type_id equal to 3 - and check if it's an integer.

When I post my form, the rules works when I select a type_id equal to 3. But if I select another type_id, like 1 or 2, the validation does not pass :

The external_id must be an integer.

I try to add the nullable condition but required_if does not work anymore

Did you have any idea ?

Upvotes: 18

Views: 62999

Answers (5)

Jazuly
Jazuly

Reputation: 1424

i think the easy way is

'type_id'     => 'required|integer',
'external_id' => $this->type_id === 3 ? 'required|integer' : 'nullable',

Upvotes: 0

Harshad-rk
Harshad-rk

Reputation: 1

try this pass the value directly refer: https://www.npmjs.com/package/validatorjs

"required_if:anotherfield,value"

The field under validation must be present and not empty if the another field field is equal to any value.

'type_id'     => 'required|integer',
'external_id' => 'required_if:type_i,3|integer',

Upvotes: 0

Nick A
Nick A

Reputation: 399

Just came across the same problem and found the following answer that seems to work for me:

issue-using-required-if-validation-rule-in-form-builder

     return [
                'type_id'     => 'required|integer',
                'external_id' => 'required_if:type_id,==,3|nullable|integer',
            ];

Result for me:

field not populated, type id not 3 - pass

field not populated, type id 3 - fail - required field

field populated, type id 3, non-integer - fail in integer rule

field populated, type id 3, integer - pass - all good!

note - think nullable rule came in Laravel 5.3

Upvotes: 36

ashanrupasinghe
ashanrupasinghe

Reputation: 756

try this,

  class StoreRequest extends Request
    {
            public function authorize(){
            return true;
            }

            public function rules(){
                    return [
                        'type_id'     => 'required|integer',
                        'external_id' => 'required_if:type_id|in:3|integer',
                    ];
            }
    }

Upvotes: -2

Graham
Graham

Reputation: 6562

Your rule performs two checks that are independent of one another; just because the external_id field is not required when the type_id != 3, does not mean the integer check is ignored.

What you are looking for is a conditional rule, which gives you finer control of when to perform a check, e.g. :

$validator = Validator::make($data, [
    'type_id'   => 'required|integer'
]);

$validator->sometimes('external_id', 'required|integer', function($input) {
    return $input->type_id == 3;
});

When using form validation, you can access the underlying validator instance by overriding the getValidatorInstance() method:

class StoreRequest extends Request
{
        public function authorize(){
        return true;
        }

        public function rules(){
                return [
                    'type_id'     => 'required|integer'
                ];
        }

        protected function getValidatorInstance() {
            $validator = parent::getValidatorInstance();
            $validator->sometimes('external_id', 'required|integer', function($input) {
                return $input->type_id == 3;
            });
            return $validator;
        }
}

Upvotes: 14

Related Questions