MikeMB
MikeMB

Reputation: 21146

libc++ doesn't allow construction of shared_ptr<T> from unique_ptr<T[]>

Is there any reason why the following should not work in c++11 (or later)?

#include <memory>

int main()
{
    auto up = std::unique_ptr<int[]>(new int[5]{});
    auto sp = std::shared_ptr<int>(std::move(up));
}

My expectation was that this would use the 13th constructor listed here at cppreference.com.

When checking at https://gcc.godbolt.org/, visual studio and gcc compile this without a problem, but clang++ - or more specifically libc++ (-stdlib=libc++) - throws an elaborate error:

<source>:6:13: error: no matching conversion for functional-style cast from 'typename remove_reference<unique_ptr<int const[], default_delete<int const[]> > &>::type' (aka 'std::__1::unique_ptr<int const[], std::__1::default_delete<int const[]> >') to 'std::shared_ptr<const int>'
auto sp = std::shared_ptr<const int>(std::move(up));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[..]c++/v1/memory:3900:23: note: candidate constructor not viable: no known conversion from 'typename remove_reference<unique_ptr<int const[], default_delete<int const[]> > &>::type' (aka 'std::__1::unique_ptr<int const[], std::__1::default_delete<int const[]> >') to 'nullptr_t' for 1st argument
_LIBCPP_CONSTEXPR shared_ptr(nullptr_t) _NOEXCEPT;
^
[..]c++/v1/memory:3914:5: note: candidate constructor not viable: no known conversion from 'typename remove_reference<unique_ptr<int const[], default_delete<int const[]> > &>::type' (aka 'std::__1::unique_ptr<int const[], std::__1::default_delete<int const[]> >') to 'const std::__1::shared_ptr<const int>' for 1st argument
shared_ptr(const shared_ptr& __r) _NOEXCEPT;
^
[..]c++/v1/memory:3922:5: note: candidate constructor not viable: no known conversion from 'typename remove_reference<unique_ptr<int const[], default_delete<int const[]> > &>::type' (aka 'std::__1::unique_ptr<int const[], std::__1::default_delete<int const[]> >') to 'std::__1::shared_ptr<const int>' for 1st argument
shared_ptr(shared_ptr&& __r) _NOEXCEPT;
^
[..]c++/v1/memory:3902:18: note: candidate template ignored: could not match '_Yp *' against 'typename remove_reference<unique_ptr<int const[], default_delete<int const[]> > &>::type' (aka 'std::__1::unique_ptr<int const[], std::__1::default_delete<int const[]> >')
explicit shared_ptr(_Yp* __p,
^
[..]c++/v1/memory:3917:9: note: candidate template ignored: could not match 'shared_ptr' against 'unique_ptr'
shared_ptr(const shared_ptr<_Yp>& __r,
^
[..]c++/v1/memory:3923:52: note: candidate template ignored: could not match 'shared_ptr' against 'unique_ptr'
template<class _Yp> _LIBCPP_INLINE_VISIBILITY  shared_ptr(shared_ptr<_Yp>&& __r,
^
[..]c++/v1/memory:3927:34: note: candidate template ignored: could not match 'weak_ptr' against 'unique_ptr'
template<class _Yp> explicit shared_ptr(const weak_ptr<_Yp>& __r,
^
[..]c++/v1/memory:3931:9: note: candidate template ignored: could not match 'auto_ptr' against 'unique_ptr'
shared_ptr(auto_ptr<_Yp>&& __r,
^
[..]c++/v1/memory:3943:24: note: candidate template ignored: disabled by 'enable_if' [with _Yp = int const[], _Dp = std::__1::default_delete<int const[]>]
!is_lvalue_reference<_Dp>::value &&
^
[..]c++/v1/memory:3952:24: note: candidate template ignored: disabled by 'enable_if' [with _Yp = int const[], _Dp = std::__1::default_delete<int const[]>]
is_lvalue_reference<_Dp>::value &&
^
[..]c++/v1/memory:3905:9: note: candidate constructor template not viable: requires at least 2 arguments, but 1 was provided
shared_ptr(_Yp* __p, _Dp __d,
^
[..]c++/v1/memory:3908:9: note: candidate constructor template not viable: requires at least 3 arguments, but 1 was provided
shared_ptr(_Yp* __p, _Dp __d, _Alloc __a,
^
[..]c++/v1/memory:3910:26: note: candidate constructor template not viable: requires 2 arguments, but 1 was provided
template <class _Dp> shared_ptr(nullptr_t __p, _Dp __d);
^
[..]c++/v1/memory:3911:40: note: candidate constructor template not viable: requires 3 arguments, but 1 was provided
template <class _Dp, class _Alloc> shared_ptr(nullptr_t __p, _Dp __d, _Alloc __a);
^
[..]c++/v1/memory:3912:51: note: candidate constructor template not viable: requires 2 arguments, but 1 was provided
template<class _Yp> _LIBCPP_INLINE_VISIBILITY shared_ptr(const shared_ptr<_Yp>& __r, element_type* __p) _NOEXCEPT;
^
[..]c++/v1/memory:3898:23: note: candidate constructor not viable: requires 0 arguments, but 1 was provided
_LIBCPP_CONSTEXPR shared_ptr() _NOEXCEPT;
^
1 error generated.
Compiler exited with result code 1

Upvotes: 2

Views: 2340

Answers (2)

Emil Laine
Emil Laine

Reputation: 42828

The standard (pre-C++17) only says the following about the 13th constructor:

This constructor shall not participate in overload resolution unless unique_ptr<Y, D>::pointer is convertible to T*.

But since std::unique_ptr<int[]>::pointer is convertible to int* the code should work. It's a bug in libc++.

In the meantime you can use the following:

auto sp = std::shared_ptr<int>(up.release(), up.get_deleter());

Upvotes: 4

Zan Lynx
Zan Lynx

Reputation: 54325

Your types are different: int[] is not int.

Upvotes: 3

Related Questions