CODEWITHSUNDEEP
pythonpython-2.7pygame
iMiner
iMiner

Reputation: 43

How do I get my object in pygame to move by holding the button?

I tried using something like this but it did not work.

while running:
keys = pygame.key.get_pressed()  #checking pressed keys
if keys[pygame.K_UP]:
    y1 -= 1
if keys[pygame.K_DOWN]:
    y1 += 1

Here is the code I have at the moment. I tried using a different method because the above method did not work for me. It moves it one button tap at a time.

import pygame
spaceX = 100
spaceY = 100
pygame.init
black = (0,0,0)
size = (800, 800)
screen = pygame.display.set_mode(size)

def game(spaceX, spaceY):
    spaceship_file = 'spaceship.png'
    spaceship_image = pygame.image.load(spaceship_file)
    spaceship = pygame.transform.scale(spaceship_image, (30, 30))
    screen.fill(black)
    screen.blit(spaceship, (spaceX, spaceY))
    pygame.display.flip()

    while True:
        for event2 in pygame.event.get():
            if event2.type == pygame.KEYDOWN and event2.key == pygame.K_LEFT:
                spaceX2 = spaceX - 5
                game(spaceX2, spaceY)

            elif event2.type == pygame.KEYDOWN and event2.key == pygame.K_RIGHT:
                spaceX2 = spaceX + 5
                game(spaceX2, spaceY)

game(spaceX, spaceY)

EDIT:

I have this code now. My object still only moves when I repeatedly tap the button and not when I hold it down.

def game(spaceX, spaceY):

    while True:
        screen.fill(black)
        screen.blit(spaceship, (spaceX, spaceY))
        pygame.display.flip()
        keys = pygame.key.get_pressed()

        for event in pygame.event.get():
            if keys[pygame.K_LEFT]:
                spaceX = spaceX - 5
                game(spaceX, spaceY)

            elif keys[pygame.K_RIGHT]:
                spaceX = spaceX + 5
                game(spaceX, spaceY)

Upvotes: 2

Views: 1734

Answers (3)

Ted Klein Bergman
Ted Klein Bergman

Reputation: 9766

There are two ways to check for key input, either if they're in the event queue or checking their current state.

Event queue

Keys are put into the event queue when they're pressed or realesed, so you cannot directly tell if a key is held or not. There are two ways around this:

  1. Call pygame.key.set_repeat(True) before you enter the main loop. This will repeatedly put the KEYDOWN event into the event queue, as long as it's held.

  2. Introduce a velocity variable. Set the velocity to some speed when the user press down the key, and set the velocity to 0 when the user lift the key.

For example:

for event in pygame.event.get():
    if event.type == pygame.KEYDOWN:
        if event.key == pygame.K_LEFT:
            velocity_x = -5
        elif event.key == pygame.K_RIGHT:
            velocity_x = 5
    elif event.type == pygame.KEYUP:
        if event.key == pygame.K_LEFT:
            velocity_x = 0
        elif event.key == pygame.K_RIGHT:
            velocity_x = 0

position_x += velocity_x

State checking

You get the current state of the keys by calling pygame.key.get_pressed(). You have to call one of the functions in pygame.event in order for pygame to do some required internal actions, so use pygame.event.pump() if you don't want to use the event queue. Your OS will think pygame has crashed if you don't, resulting in the game being unresponsive. Although, you usually want to handle the pygame.QUIT event, so the user can quit.

pygame.event.pump()
keys = pygame.key.get_pressed()
if keys[pygame.K_LEFT]:
    position_x -= 5
elif keys[pygame.K_RIGHT]:
    position_x += 5

Upvotes: 3

user6698006
user6698006

Reputation:

Try adding the keys to your pygame for loop. So it should look something like this...

while running:
for event in pygame.event.get():
    keys = pygame.key.get_pressed()  #checking pressed keys
        if keys[pygame.K_UP]:
        y1 -= 1

        if keys[pygame.K_DOWN]:
        y1 += 1

Upvotes: 0

mic4ael
mic4ael

Reputation: 8310

One solution to this problem would be to use set_repeat function

pygame.key.set_repeat(True)

This will generate multiple KEYDOWN events.

Upvotes: 0

Related Questions