CODEWITHSUNDEEP
javaspringaspectjspring-aop
Patan
Patan

Reputation: 17873

AOP for inner and private methods Java

I am trying to log the execution time for methods annotated with custom interface.

I am using Spring AOP.

But this does not seems to work for inner methods.

I think it is the limitation in Spring AOP

@Aspect
public class BusinessProfiler {

  private static Log log = LogFactory.getLog(BusinessProfiler.class);


  @Around("execution(* *(..)) && @annotation(TimeLog)")
  public Object profile(ProceedingJoinPoint point) throws Throwable {
    long start = System.currentTimeMillis();
    Object result = point.proceed();
    String format =
        String.format("%s#%s: took [%s msec]", point.getTarget().getClass().getSimpleName(),
            MethodSignature.class.cast(point.getSignature()).getMethod().getName(),
            System.currentTimeMillis() - start);
    log.info(format);
    return result;
  }

}

Are there any alternatives than Spring AOP

Upvotes: 3

Views: 3988

Answers (1)

Essex Boy
Essex Boy

Reputation: 7950

If you think about the way AOP annotations are dealt with by Spring this will be clear:

Spring takes your class and wraps it in a proxy with the extra code generated on the fly by the AOP annotation added. So only code called via the proxy (i.e from outside your class will be included).

Example

@Service
public class Foo {

  public void doSomething() {
      doSomethingInternal();
  }

  public void doSomethingInternal() {
  }
}

If from another Spring bean I do this:

@Service
public class Bar {

  @Autowired
  private Foo foo;

  public void execute() {
      foo.doSomething();
  }
}

Only doSomething will be called via the proxy which wraps your class, not doSomethingInternal, that will be called by your class.

Upvotes: 3

Related Questions