CODEWITHSUNDEEP
pythondownloadftpdirectoryftplib
user7220644
user7220644

Reputation:

Problems downloading files from ftp server to directory

I am trying to download files from an ftp server to a local folder. Below I have included my code, the script is able to access the ftp succesfully and list the names of the files on the ftp server however where my issue lies is I am not sure how to download them to a local directory.

from ftplib import FTP
import os, sys, os.path

def handleDownload(block):
    file.write(block)

ddir='U:/Test Folder'
os.chdir(ddir)
ftp = FTP('sidads.colorado.edu')
ftp.login()

print ('Logging in.')
directory = '/pub/DATASETS/NOAA/G02158/unmasked/2012/04_Apr/'

print ('Changing to ' + directory)
ftp.cwd(directory)
ftp.retrlines('LIST')

print ('Accessing files')

filenames = ftp.nlst() # get filenames within the directory
print (filenames)

I tried using the following code below however it gives me the error in the photo below.

for filename in filenames:
    if filename != '.':
        local_filename = os.path.join('U:/Test Folder/',                   filename)
    file = open(local_filename, 'wb')
    ftp.retrbinary('RETR '+ filename, file.write)
    file.close()
ftp.quit()

enter image description here

Upvotes: 1

Views: 1239

Answers (1)

Martin Evans
Martin Evans

Reputation: 46759

Try the following:

for filename in filenames:
    if filename not in ['.', '..']:
        local_filename = os.path.join(ddir, filename)

        with open(local_filename, 'wb') as f_output:
            ftp.retrbinary('RETR '+ filename, f_output.write)

ftp.quit()

Your code was still attempting to download . filenames. You need to indent the writing of the valid filenames. Also by using with it will close the file automatically.

Upvotes: 1

Related Questions