Next row or id gets deleted from table and database

Question

I have a table of chapters for which I have a delete button for each one. When I am clicking on delete button if the table has more records further the last row of the table gets deleted or the id of row getting pass to the database is wrong.




Files







Select rank :





     
 
 




    

prepare("DELETE FROM `files` WHERE `id`= " . $_POST['id']); 

    $stmt->execute(); 
    $result = $stmt->fetch(PDO::FETCH_ASSOC); 

        if(count($result) > 0)
        {
          echo 'row deleted';
        }
        else{
            echo 'row could not delete';    
        }
    }


if(isset($_POST['type']))
{
    $stmt = $dbh->prepare("SELECT * FROM files where type = :type"); 
    $stmt->bindParam("type", $_POST['type']);
    $stmt->execute(); 
    $results = $stmt->fetchall(PDO::FETCH_ASSOC);

}
    else{
        $stmt = $dbh->prepare("SELECT * FROM files"); 
    $stmt->execute(); 
    $results = $stmt->fetchall(PDO::FETCH_ASSOC);

}

    foreach($results as $file)

    {
    ?>
     
    
    Files

EDIT:

    


Video Files









    




Select rank :

    


    
    
    
    
    
    
    


    

prepare("DELETE FROM `videos` WHERE `id`= :id");
        $stmt->bindParam("id", $_POST['id']);
        $stmt->execute();
        $result = $stmt->fetch(PDO::FETCH_ASSOC);

        if(count($result) < 0)
        {
            echo 'row could not delete';
        }
    }

    if(isset($_POST['type']))
    {

        if(!empty($_POST['type']))

        {

            $stmt = $dbh->prepare("SELECT * FROM `videos` where type = :type");
            $stmt->bindParam("type", $_POST['type']);
            $stmt->execute();
            $results = $stmt->fetchall(PDO::FETCH_ASSOC);
            if(count($results) == 0)
            {
                echo 'No records available.';
            }
        }
        else{

            echo 'empty type';
            $stmt = $dbh->prepare("SELECT * FROM `videos`");
            $stmt->execute();
            $results = $stmt->fetchall(PDO::FETCH_ASSOC);
            if(count($results) == 0)
            {
                echo 'No records available.';
            }

        }
    }
  /*  elseif(!empty($_SESSION['vidType'])){

        echo $_SESSION['vidType'];
        echo $_POST['type'];

            $stmt = $dbh->prepare("SELECT * FROM `videos` where type = :type");
            $stmt->bindParam("type", $_SESSION['vidType']);
            $stmt->execute();
            $results = $stmt->fetchall(PDO::FETCH_ASSOC);
            if(count($results) == 0)
            {
                echo 'No records available.';
            }
    }*/

    else{

            $stmt = $dbh->prepare("SELECT * FROM `videos`");
            $stmt->execute();
            $results = $stmt->fetchall(PDO::FETCH_ASSOC);
            if(count($results) == 0)
            {
                echo 'No records available.';
            }
    }
    foreach($results as $file)

    {
        ?>
        
    
        Video Files

I am sending the id of chapter in for each loop, What is the problem here? Please help thank you..

Accountant م · Accepted Answer

That is because building the form element this way is going to result for many id inputs inside the same form. something like this

on your server code the php will set $_POST['id'] to the last one which in this case 2. that is why when press delete button and submit the form you delete the next , or last id you have built in your form

If you need your code work the way you want you have to put every id in different form element, Or you will need some javascript work.

I prefer building different form for each record. replace that code

foreach($results as $file)
{
?>

with something like this

foreach($results as $file)
{
?>

Another note :

$stmt = $dbh->prepare("DELETE FROM `files` WHERE `id`= " . $_POST['id']);

using prepared statements this way makes you still vulnerable to SQL injection.

EDIT(reaction to comments) to send another input along with the delete forms to the PHP server. you can use JavaScript for that.

1- add that class deleteForm to the delete forms so we can catch those forms and bind to only them.

2- edit that script tag in your document

Next row or id gets deleted from table and database

Answers (1)

Related Questions