Martijn
Martijn

Reputation: 24789

How to insert a Guid into the database with Log4net?

Here is my log4net.config

<?xml version="1.0" encoding="utf-8"?>
<log4net>
    <root>
        <level value="ALL" />
    </root>

    <logger name="RequestLogger">
        <level value="INFO" />
        <appender-ref ref="AdoNetAppenderForRequestLogs" />
    </logger>

    <appender name="AdoNetAppenderForRequestLogs" type="log4net.Appender.AdoNetAppender">
        <bufferSize value="1" />
        <connectionType value="System.Data.SqlClient.SqlConnection, System.Data, Version=1.0.3300.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
        <connectionString value="" />
        <commandText value="INSERT INTO Log4net_Requests ([Guid], [Date], [Url], [Headers], Controller, Action, RouteData) VALUES (@guid, @log_date, @url, @headers, @controller, @action, @routeData)" />
        <parameter>
            <parameterName value="@guid" />
            <dbType value="Guid" />
            <layout type="log4net.Layout.PatternLayout">
                <conversionPattern value="%property{RequestGuid}" />
            </layout>
        </parameter>
        <parameter>
            <parameterName value="@log_date" />
            <dbType value="DateTime" />
            <layout type="log4net.Layout.RawTimeStampLayout" />
        </parameter>
        <parameter>
            <parameterName value="@url" />
            <dbType value="String" />
            <size value="2000" />
            <layout type="log4net.Layout.PatternLayout">
                <conversionPattern value="%property{Url}" />
            </layout>
        </parameter>
        <parameter>
            <parameterName value="@headers" />
            <dbType value="String" />
            <layout type="log4net.Layout.PatternLayout">
                <conversionPattern value="%property{Headers}" />
            </layout>
        </parameter>
        <parameter>
            <parameterName value="@controller" />
            <dbType value="String" />
            <layout type="log4net.Layout.PatternLayout">
                <conversionPattern value="%property{Controller}" />
            </layout>
        </parameter>
        <parameter>
            <parameterName value="@action" />
            <dbType value="String" />
            <layout type="log4net.Layout.PatternLayout">
                <conversionPattern value="%property{Action}" />
            </layout>
        </parameter>
        <parameter>
            <parameterName value="@routeData" />
            <dbType value="String" />
            <layout type="log4net.Layout.PatternLayout">
                <conversionPattern value="%property{RouteData}" />
            </layout>
        </parameter>
    </appender>
</log4net>

In my code I set the properties like this: Request.Id is already a valid Guid.

GlobalContext.Properties["Url"] = RequestLog.Url;
GlobalContext.Properties["RequestGuid"] = RequestLog.Id; // .ToString() doesn't work either
GlobalContext.Properties["Headers"] = RequestLog.GetHeaders();
GlobalContext.Properties["Controller"] = RequestLog.Controller;
GlobalContext.Properties["Action"] = RequestLog.Action;
GlobalContext.Properties["RouteData"] = RequestLog.RouteData;

When I try to log, I get this Exception in my log4net.txt log file

System.InvalidCastException: Failed to convert parameter value from a String to a Guid. ---> System.InvalidCastException: Invalid cast from 'System.String' to 'System.Guid'.
   at System.Convert.DefaultToType(IConvertible value, Type targetType, IFormatProvider provider)
   at System.String.System.IConvertible.ToType(Type type, IFormatProvider provider)
   at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
   at System.Data.SqlClient.SqlParameter.CoerceValue(Object value, MetaType destinationType, Boolean& coercedToDataFeed, Boolean& typeChanged, Boolean allowStreaming)
   --- End of inner exception stack trace ---
   at System.Data.SqlClient.SqlParameter.CoerceValue(Object value, MetaType destinationType, Boolean& coercedToDataFeed, Boolean& typeChanged, Boolean allowStreaming)
   at System.Data.SqlClient.SqlParameter.GetCoercedValue()
   at System.Data.SqlClient.SqlParameter.Validate(Int32 index, Boolean isCommandProc)
   at System.Data.SqlClient.SqlCommand.BuildParamList(TdsParser parser, SqlParameterCollection parameters, Boolean includeReturnValue)
   at System.Data.SqlClient.SqlCommand.BuildExecuteSql(CommandBehavior behavior, String commandText, SqlParameterCollection parameters, _SqlRPC& rpc)
   at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
   at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at log4net.Appender.AdoNetAppender.SendBuffer(IDbTransaction dbTran, LoggingEvent[] events)
   at log4net.Appender.AdoNetAppender.SendBuffer(LoggingEvent[] events)

If I remove the guid, the log is stored in the DB, so I know everything is except the guid part.

What do I need to do to fix this?

Upvotes: 3

Views: 1146

Answers (3)

Dmitry
Dmitry

Reputation: 1

Use GUID in SQL, but String in config file.

LogicalThreadContext.Properties["RequestID"] = requestID.ToString();

<parameter>
  <parameterName value="@RequestID" />
  <dbType value="String" />
  <size value="36" />
  <layout type="log4net.Layout.PatternLayout">
    <conversionPattern value="%property{RequestID}" />
  </layout>
</parameter>

Upvotes: 0

Seafish
Seafish

Reputation: 2271

Use a RawPropertyLayout instead of a PatternLayout:

<parameter>
    <parameterName value="@guid" />
    <dbType value="Guid" />
    <layout type="log4net.Layout.RawPropertyLayout">
        <key value="RequestGuid" />
    </layout>
</parameter>

Upvotes: 2

Giorgos Betsos
Giorgos Betsos

Reputation: 72175

Try to create a new Guid object and assign this to RequestGuid property:

GlobalContext.Properties["RequestGuid"] = new Guid(RequestLog.Id);

As stated in the MSDN link provided, the constructor used above:

Initializes a new instance of the Guid structure by using the value represented by the specified string.

Upvotes: 1

Related Questions