CODEWITHSUNDEEP
androidmemory-leaksandroid-videoview
zbx
zbx

Reputation: 289

VideoView memory leak

Has any of you encountered a similar memory leak? This is how I'm handling the VideoView at the moment

@Override
protected void onFinishInflate() {
    super.onFinishInflate();
    ButterKnife.bind(this);

    Uri videoUri = Uri.parse(String.format("android.resource://%s/%s", getContext().getPackageName(), videoRes));
    videoView.setVideoURI(videoUri);
    videoView.setOnPreparedListener(mp -> {
        mp.setLooping(true);
        videoView.start();
    });
}

This is what I get on LeakCanary

enter image description here

Any help appreciated!

Upvotes: 4

Views: 3074

Answers (4)

吴健宁
吴健宁

Reputation: 11

Call videoView.suspend() in onPause() or onDestory().

Upvotes: 1

Someone Somewhere
Someone Somewhere

Reputation: 23787

This fixed it for me within an AppCompatActivity that's not using Butterknife

Step 1: Create a utility class

public class AudioServiceContext extends ContextWrapper {

    public AudioServiceContext(Context base) {
        super(base);
    }

    public static ContextWrapper getContext(Context base) {
        return new AudioServiceContext(base);
    }

    @Override
    public Object getSystemService(String name) {
        if (Context.AUDIO_SERVICE.equals(name)) {
            return getApplicationContext().getSystemService(name);
        }
        return super.getSystemService(name);
    }
}

Step 2: within your Activity, use this utility class

public class YourVideoActivity extends AppCompatActivity {

    private VideoView videoView;

    @Override
    protected void attachBaseContext(Context newBase) {
        super.attachBaseContext(AudioServiceContext.getContext(newBase));
    }

    //etc...
}

Credit: https://medium.com/@chauyan/confirmed-videoview-leak-on-android-ac502856a6cf

Upvotes: 3

Yasmin B.
Yasmin B.

Reputation: 21

If you are using Butterknife make sure to unbind, and if you aint't make sure to call videoView.stopPlayback() in your onDestroy

Upvotes: 0

Submersed
Submersed

Reputation: 8870

When using ButterKnife with Fragments, you need to use the Unbinder in onDestroyView() to correctly dereference the Fragment's Views -- since Fragments have different life cycles to Activities.

There is a related issue here.

Upvotes: 2

Related Questions