CODEWITHSUNDEEP
python
Alex Rosenbach
Alex Rosenbach

Reputation: 85

Python Class Setters Not Changing Variables

The closest thread I could find to my problem was this: Python setter does not change variable

It didn't really help, the volume and the channels are not changing at all. The first fucntion which is to "watch TV" works perfectly fine.

class TV(object):

    def __init__(self, channel, volume):
        self.__channel = channel
        self.__volume = volume

    def __str__(self):
        out = ""
        out += "You're on channel #" + str(self.__channel) + ", " +     self.channelNetwork()
    out += "\nVolume is currently at: " + str(self.__volume) + "/20"
    return out

# a method that determines the name for each channel from 1-10

def channelNetwork(self):
    c = self.__channel
    if c == 1:
        return "CBS"
    elif c==2:
        return "NBC"
    elif c==3:
        return "ABC"
    elif c==4:
        return "Fox"
    elif c==5:
        return "ESPN"
    elif c==6:
        return "PBS"
    elif c==7:
        return "CNN"
    elif c==8:
        return "Comedy Central"
    elif c==9:
        return "Cartoon Network"
    elif c==10:
        return "Nicklodeon"

# a volume slider that has a range from 0-20

def volumeSlider(self, newVolume):
    v = self.__volume
    if newVolume == "+":
        v += 1
    else:
        v -= 1
    if v < 0:
        v = 0
    if v > 20:
        v = 20

def channelChanger(self, newChannel):
    c = self.__channel
    if newChannel == "+":
        c += 1
    else:
        c -= 1
    if c < 0:
        c = 0
    if c > 10:
        c = 10

def main():
import random
randomChannel = random.randint(1,10)
randomVolume = random.randrange(21)
televsion = TV(randomChannel, randomVolume)

choice = None
while choice != "0":
    print \
    ("""
    TV Simulator

    0 - Turn off TV
    1 - Watch TV
    2 - Change channel
    3 - Change volume
    """)

    choice = input("Choice: ")
    print()

    # exit
    if choice == "0":
        print("Have a good day! :)")

    elif choice == "1":
        print("You relax on your couch and watch some TV")
        print(televsion)

    elif choice == "2":
        newChannel = None
        while newChannel not in ('+', '-'):
            newChannel = input("\nPress '+' to go up a channel and press '-' to go down a channel: ")
        televsion.channelChanger(newChannel)

    elif choice == "3":
        newVolume = None
        while newVolume not in ('+', '-'):
            newVolume = input("\nPress '+' to increase volume and press '-' to decrease volume: ")
        televsion.volumeSlider(newVolume)

    else:
        print("\nSorry, but", choice, "isn't a valid choice.")

main()
input("\n\nPress enter to exit.")

Upvotes: 0

Views: 330

Answers (1)

juanpa.arrivillaga
juanpa.arrivillaga

Reputation: 95948

The problem is, that when you do:

v = self.__volume

In:

def volumeSlider(self, newVolume):
    v = self.__volume
    if newVolume == "+":
        v += 1
    else:
        v -= 1
    if v < 0:
        v = 0
    if v > 20:
        v = 20

Assigning to v won't affect self.__volume. You need to use self.__volume = 20 or whatever.

As an aside, don't use double-underscore name-mangling unless you actually need it. E.g. self.volume is fine.

Upvotes: 3

Related Questions