CODEWITHSUNDEEP
javascriptjquery
Rich Bradshaw
Rich Bradshaw

Reputation: 72965

Getting my head around jQuery

OK, I'm designing a site and thought I'd stick some jQuery in as I really need so js experience.

Page with my problem is here: http://new.focalpix.co.uk/moreinfo.php

JS in question is:

$(document).ready(function(){

    $(".answer").css("display","none");

    $("#maincontent a.animate").click(function() {
        $("#maincontent .answer").slideUp('slow');
        var id = $(this).attr('href');
        $(id).slideDown('slow');
        return false;
    });

});

This works fine, but if you click on a link where the answer has already slid down, then it slides up, then back down again.

I'm not sure on the cleanest way to stop this happening - any ideas?

Upvotes: 2

Views: 406

Answers (4)

Ry Biesemeyer
Ry Biesemeyer

Reputation: 1494

First, I'd suggest the following structure for your faq's:

<div id="faq">
  <div class="qa" id="faq_greenandflies">
    <span class="q">What is <a href="#faq_greenandflies">green and flies</a></span>
    <div class="a">
      Super Pickle!
    </div>
  </div>
  <div class="qa" id="faq_redandbadforteeth">
    <span class="q">What is <a href="#faq_redandbadforteeth">Red and bad for your teeth</a></span>
    <div class="a">
      a Brick
    </div>
  </div>
  <!--
  More FAQ's here

  -->
</div>

and then defining your jQuery as follows:

 <script type="text/javascript">
    $(function(){
  // hide all answers
  $('div#faq .qa .a').hide();

      // bind a click event to all questions
  $('div#faq .qa .q a').bind(
        'click',
        function(e){
          // roll up all of the other answers (See Ex.1)
          $(this).parents('.qa').siblings().children('.a').slideUp();
          // reveal this answer (See Ex.2)
          $(this).parents('.qa').children('.a').slideDown();
          // return true to keep any other click events       
          return true;
        });

      // check location.hash to see if we need to expand one (direct link)
      $(location.hash).find('.q a').click();
    });
</script>

Explanation:

(Ex.1)

  • this is the link that was clicked
  • get the element that contains this and has a class of 'qa' (the box that contains both question and answer)
  • select all of its siblings. (we now have all qa's as a jQ object)
  • hide the answers

(Ex.2)

  • this is the line or link that was clicked
  • get the element that contains this and has a class of 'qa' (the box that contains both question and answer)
  • reveal the answer

A working demo is here.

This does several things for you:

  • If a user deep-links to an answer, the answer is automatically revealed
  • If a user clicks on one answer, all other answers are hidden
  • You can give your divs proper ids, so which helps search engine optimization of links to individual answers

Upvotes: 5

Logan Serman
Logan Serman

Reputation: 29880

Use slideToggle() like Soviut said, but just as a tip -- you can declare the display property in the actual CSS file instead of declaring it inside the javascript. jQuery will pick up on the fact that it is hidden in the stylesheet and still perform the appropriate slide function.

You can also use $(".answer").hide();

Instead of setting the display CSS property. Just thought I would let you know.

Upvotes: 0

Pim Jager
Pim Jager

Reputation: 32119

try using the one method, something like:

 $(selector).one('effect', 'data for effect', callback function);

it makes sure an effect only happens once per element.

Upvotes: -3

Soviut
Soviut

Reputation: 91555

You should be using the .slideToggle() effect.

$(document).ready(function() {
    $(".answer").css("display","none");
    $("#maincontent a.animate").click(function() {
        $("#maincontent .answer").slideToggle('slow');
    });
});

Upvotes: 7

Related Questions