CSharpie
CSharpie

Reputation: 9467

Get enum values via reflection from nested enum in generic class

I need to print out enum values and their corresponding underyling values from certain types i accquire through reflection. This works fine most of the time. However if the enum is declared within a generic type, Enum.GetValues throws the following exception:

[System.NotSupportedException: Cannot create arrays of open type. ]  
at System.Array.InternalCreate(Void* elementType, Int32 rank, Int32* pLengths, Int32* pLowerBounds)    
at System.Array.CreateInstance(Type elementType, Int32 length)
at System.Array.UnsafeCreateInstance(Type elementType, Int32 length)   
at System.RuntimeType.GetEnumValues()

Full code for reproduction :

using System;

public class Program
{
    public static void Main()
    {
       var enumType= typeof(Foo<>.Bar);
       var underlyingType = Enum.GetUnderlyingType(enumType);
       Console.WriteLine(enumType.IsEnum);

       foreach(var value in Enum.GetValues(enumType))
       {
           Console.WriteLine("{0} = {1}", value, Convert.ChangeType(value, underlyingType));
       }
    }

}

public class Foo<T>
{
    public enum Bar
    {
        A = 1,
        B = 2
    }
}

Or test it here

Is this desired behaviour and how do I work arround?

Constructing a type would be a workarround but inacceptable for me, since it would get too complicated.

Upvotes: 37

Views: 6164

Answers (3)

Jon Skeet
Jon Skeet

Reputation: 1500665

Construction a type would be a workaround but inacceptable for me, since it would get too complicated.

That's the only way of getting values that will behave normally.

You can get at the fields of an open type, and the bizarre thing is that you can get values that way for enums. You should try to avoid using those values, but you can convert them to their underlying type.

public static void Main()
{
   var enumType = typeof(Foo<>.Bar);
   var underlyingType = Enum.GetUnderlyingType(enumType);

   foreach(var field in enumType.GetFields(BindingFlags.Public | BindingFlags.Static))
   {
       var value = field.GetValue(null);
       var underlyingValue = Convert.ChangeType(value, underlyingType);
       Console.WriteLine($"{field.Name} = {underlyingValue}");
   }
}

However, a better solution is to use field.GetRawConstantValue():

public static void Main()
{
   var enumType = typeof(Foo<>.Bar);

   foreach(var field in enumType.GetFields(BindingFlags.Public | BindingFlags.Static))
   {
       Console.WriteLine($"{field.Name} = {field.GetRawConstantValue()}");
   }
}

That way if the CLR is ever fixed to prevent such weird values from ever being produced, your code won't break.

Upvotes: 49

Akos Nagy
Akos Nagy

Reputation: 4350

This is the expected behavior. Open generic types cannot exist at runtime, so neither can anything that lives inside them. The only way you can do this is first closing the parent type with any type, and then using that to reflect the enum:

 var enumType = typeof(Foo<object>.Bar);

Upvotes: 3

areller
areller

Reputation: 5238

Foo is what's called an open type (A type which is not fully defined because it has a generic in it) And array of open type is not allowed, you could simulate it by doing

Array.CreateInstance(typeof(Foo<>), 2)

And since GetValues of Enum is dependent upon creating an array, it fails. You could instead do

var enumType = typeof(Foo<object>.Bar);

("object" being a dummy type so that you won't work with an open type) Or do what Jon Skeet suggested.

Upvotes: 2

Related Questions