CODEWITHSUNDEEP
pythonreadfilewritefile
jacky
jacky

Reputation: 524

python read value from file and change it and write back to file

i am reading a value from a file and then adding up with another and then writing back to the same file.

total = 0
initial = 10
with open('file.txt', 'rb') as inp, open('file.txt', 'wb') as outp:
    content = inp.read()
    try:
        total = int(content) + int(initial)
        outp.write(str(total))
    except ValueError:
        print('{} is not a number!'.format(content))

it is successfully reading the value from file, but when writing, nothing is stored in the file. what is wrong here?

update

I want to replace the old value, not append to it. Erase the old value and then put the new value instead.

Upvotes: 1

Views: 5215

Answers (2)

Liam
Liam

Reputation: 6439

you can't open your file twice simultaneously, your code should look like this:

total = 0
initial = 10

with open('file.txt', 'rb') as inp:
    content = inp.read()
    total = int(content) + int(initial)

with open('file.txt', 'wb') as outp:
    outp.write(str(total))

A look at this could help you: Beginner Python: Reading and writing to the same file

Upvotes: 4

Q Caron
Q Caron

Reputation: 1043

I do not know which Python version you use, but both 2.7.13 and 3.6.1 versions give me the following error: b'' is not a number!. So because an error is raised, the write instruction is not interpreted.

The with statement is evaluated from left to right. So first, your file is open in read mode. Right after that, it is open in write mode and that causes the file to be truncated: there is nothing more to read.

You should proceed in two steps:

total = 0
initial = 10

# First, read the file and try to convert its content to an integer
with open('file.txt', 'r') as inp:
    content = inp.read()

    try:
        total = int(content) + int(initial)
    except ValueError:
        print('Cannot convert {} to an int'.format(content))


with open('file.txt', 'w') as outp:
    outp.write(str(total))

Upvotes: 4

Related Questions