CODEWITHSUNDEEP
python
Aditya
Aditya

Reputation: 986

Why Can't I break out of the loop?

Python beginner here. Sorry if it's a basic python concept

over = False

def run():
    user_input = input("Over? (y/n): ")
    if(user_input == 'y'):
        over = True

while not over:
    run()

Although the input is 'y' the loop doesn't stop.

Upvotes: 0

Views: 54

Answers (3)

chepner
chepner

Reputation: 532238

You shouldn't be using a global variable here. Return a boolean, and call run as the condition of the loop. (At this point, you may want to reconsider the name run as well.)

def run():
    user_input = input("Over? (y/n)")
    return user_input == 'y'

while run():
    ...

Upvotes: 1

Craig
Craig

Reputation: 4855

You are setting the local variable over inside the function run(), but you aren't passing it out to the scope from which it was called. Instead return the value to the calling scope like this:

over = False

def run():
    user_input = input("Over? (y/n): ")
    if(user_input == 'y'):
        over = True
    else:
        over = False
    return over

while not over:
    over = run()

Upvotes: 0

Sklert
Sklert

Reputation: 242

You need to write global over, so function run() will change global variable

over = False

def run():
    global over
    user_input = input("Over? (y/n): ")
    if(user_input == 'y'):
        over = True

while not over:
    run()

Upvotes: 1

Related Questions