CODEWITHSUNDEEP
javascriptjqueryajax
starrr
starrr

Reputation: 41

jQuery AJAX Callback function doesn't work as expected :

I'm trying to get the data out of the success part of an AJAX call. So I tried to write a callback function for that purpose. I have this code : 

  var data2;
  $(function () {
    function callback(data) {
      console.log(data);
      data2 = JSON.parse(data);
      console.log(data2);
    }

    $("myForm")
      .submit(function (event) {
        $.ajax({
          type: 'POST',
          url: "/...",
          data: "JASON",
          success: callback
        });
      });

    console.log(data2);

  });

In the console I see this in that order : undefined, content of data and content of data2.

What I can't understand is, why am I getting undefined at first? Shouldn't I be geting the value of data first? Why is the last console.log is executed first? And most importantly, is my approach to get data from AJAX call is correct? What else can I do to get data? Thanks.

Upvotes: 0

Views: 1816

Answers (5)

Rohan Büchner
Rohan Büchner

Reputation: 5403

The JavaScript as you have it is non blocking. As the code gets run by the event loop, it'll log out whatever it needs to. Once the Ajax request gets completed, data2 will get its new value... but by then, you would have have already run the outer most console.log(data2)

 var data2;                      // no value gets assigned thus is undefined
 $(function () {

    function callback(data) {
      console.log(data);         // I get logged second
      data2 = JSON.parse(data);
      console.log(data2);        // I get logged last (now with a value, as I'm the success callback)
    }

    var frm = $("myForm");
    frm.submit(function (event) {
      $.ajax({
        type: 'post',           // post: meaning we're submitting/sending something
        url: "/...",
        dataType: "json",       // not JASON but json, (Java Script Object Notation)
        data: frm.serialize(),  // get data from the form
        success: callback
      });

     event.preventDefault();    // stop actual form submission.
    });

   console.log(data2);          // I get logged first (no value yet)

 });

Visual demo of this event loop,

Have a look at the above, the whole process is visualized using a tool that'll hopefully make things a bit clearer. (Open up the dev console, then click on run and see the magic)

As @MarcosPrez mentioned, you also have a syntax error. dataType should be json, unless you actually want to submit a text value of JASON to whatever API you're calling.

To be clear, the code you want to run next in your app (post call completion), SHOULD be in the callback, and not just next to the Ajax call.

Upvotes: 2

Alexey Samara
Alexey Samara

Reputation: 131

  1. Set normal url for request.
  2. Set response data type.
$.ajax({    
    type: 'POST',
    url: "/request/",
    dataType: "text", // json etc.
    success: function (data) {
        callback(data);
    }    
});

Manual

Upvotes: -1

Abhishek Sharma
Abhishek Sharma

Reputation: 3340

This is happening due to async nature of javascript. Since the ajax call is async, console.log(newdata2); is executed first (as said by Cleared in above answer). On success of ajax call (async), your callback functions are called.

Upvotes: 0

jackstrapp
jackstrapp

Reputation: 313

This statement: 

 console.log(newdata2);

is out of the ajax call, it is after. This means it's executed right after the call starts but not after the call ends.

Upvotes: 1

Cleared
Cleared

Reputation: 2590

The AJAX-call is asynchronous, which means that after the call has been made, the code continue to the next step before the call is completed.

So when the AJAX-call has been made, console.log(newdata2); is reached and my guess is that newdata2 is undefined.

When, after som time (even though it is a very short time) the call will get its response and the callback-function will be called.

Upvotes: 2

Related Questions