CODEWITHSUNDEEP
javasqlhibernateduplicates
ssoomm07
ssoomm07

Reputation: 33

Duplicated results in Hibernate OneToMany List

I have mapped an 1:N relation with a @OneToMany List, but when I access the list, the results are duplicated due to an OUTER JOIN. This is how the mapping looks like:

@Entity
public class Programmer

    @ElementCollection(fetch=FetchType.EAGER)
    @CollectionTable(name="emails", joinColumns=@JoinColumn(name="id", nullable=false))
    @Column(name="email", nullable=false)
    protected Set<String> emails = new HashSet<String>();

    @OneToMany(mappedBy="programmer", fetch=FetchType.EAGER)
    private List <Game> games = new ArrayList<Game>();

When I get the attribute with prog.getGames(), the results comes duplicated because the Hibernate SQL makes an OUTER JOIN:

from programmer 
left outer join emails on programmer.id=emails.id 
left outer join game on programmer.id=game.id
where programmer.id=?

Is there any solution without transforming the List into a Set? I need to get the games with prog.getGames(), can not use a custom HQL or Criteria.

Upvotes: 3

Views: 6074

Answers (3)

Saeed Farahi
Saeed Farahi

Reputation: 111

@OneToMany(mappedBy = "user", fetch = FetchType.EAGER, cascade = CascadeType.ALL)
@Fetch(FetchMode.SUBSELECT)
private List<CompanyUserEntity> companyUserRelations;

I had the same problem. companyUserRelations had duplicate objects (I mean the same pointers to the same object, not duplicated data)

So after reading @dimitry response, I added @Fetch(FetchMode.SUBSELECT) and it worked

Upvotes: 0

Dmitriy Goy
Dmitriy Goy

Reputation: 65

Ive resolved this problem with @Fetch(FetchMode.SUBSELECT)

Upvotes: 4

Naros
Naros

Reputation: 21103

While the use of Set<> fundamentally resolves your issue, I'd argue that is simply a bandaid to get the expected results you're after but it doesn't technically address the underlying problem.

You should ultimately be using the default lazy fetch strategy because I'm of the opinion that eagerly loading any associations, particularly collection-based ones, are specific to a query and therefore should be toggled when you construct specific queries and not influenced as a part of your entity mapping model as you're doing.

Consider the future where you add a new query but you're only interestesd in attributes from the aggregate root entity. Your mapping model will still impose eagerly fetching those associations, you'll consume additional resources to by having a larger persistence context which means more memory consumption and impose unnecessary database joins for something which you aren't going to use.

If there are multiple collections that you need to hydrate, I would instead recommend you consider using FetchMode.SUBSELECT instead.

If we assume your query has 10 entities being returned, the default lazy strategy with 2 collections would issue 21 queries (1 for the base result set and 2 for each loaded entity).

The benefit of SUBSELECT is that Hibernate will actually only issue 3 queries (1 for the base result set and 1 for each collection to load all collection elements for all entities). And obviously, depending on certain queries, breaking one query with left-joins into 3 queries could actually perform better at the database level too.

Upvotes: 6

Related Questions