CODEWITHSUNDEEP
c#linqsearch
Dan Hall
Dan Hall

Reputation: 1534

Better way to search a List for a string

I've implimented the following code to search a list of objects for a particular value:

List<customer> matchingContacts = cAllServer
  .Where(o => o.customerNum.Contains(searchTerm) || 
              o.personInv.lastname.Contains(searchTerm) || 
              o.personDel.lastname.Contains(searchTerm))
  .ToList();

is there a quicker or cleaner way to impliment this search?

Upvotes: 0

Views: 100

Answers (3)

James Curran
James Curran

Reputation: 103575

The one thing I'd suggest is to create a new "searchtext" column, prepopulated with (o.customerNum + "|" + o.personInv.lastname + "|" + o.personDel.lastname).ToUpper().

List<customer> matchingContacts = cAllServer
  .Where(o => o.searchtext.Contains(searchTerm))
  .ToList();

This performs one search instead of three (but on a longer string), and it you .ToUpper() searchTerm, you can perform a case-sensivitive search which migh tbe trivial faster.

On the whole, I wouldn't expect this to be significantly faster.

Upvotes: 0

papadoble151
papadoble151

Reputation: 646

Since you will have to iterate through all of the list items, it will have O(n) complexity. Performance also depends whether you are operating on IQueryable collection (with or without lazy loading) or it is a serialized IEnumerable collection. I'd advise to check first the properties that are most likely to have the value you are searching for, because you are using "or" operator, so that you can speed up your "Contains" operation. You iterate more quickly if you know that it is a match for a particular entity in 10ms rather than in 25ms. There is also a popular argument what is faster? Contains or IndexOf? Well IndexOf should be a little bit faster, but I doubt you'll notice it, unless you operate on lists with millions of elements. Is String.Contains() faster than String.IndexOf()?

Upvotes: 1

Zalomon
Zalomon

Reputation: 553

I think that this is fine as it is, but in other hand I'd think twice about the need to convert to list, you already are receving an IEnumerable type that'll let you iterate through stuff. Unless you need to go back and forth the list and searching by index there's no need for you to convert it to List.

This is an small optimization though.

Upvotes: 0

Related Questions