CODEWITHSUNDEEP
phpoopinheritancemethodsabstract
JazZ
JazZ

Reputation: 4579

Abstract method with variable list of arguments in PHP

I came across a question in OOP in PHP. I tried to implement an abstract parent class method and from the child class, I have to use it with a variable number of arguments.

Here is the error thrown :

PHP Fatal error: Declaration of Square::getArea($length) must be compatible with Shape::getArea()

And the classes : 

abstract class Shape {
    abstract protected function getArea();
}

class Square extends Shape {

    public function getArea($length)
    {
        return pow($length, 2);
    }

}

class Triangle extends Shape {

    public function getArea($base, $height)
    {
        return .5 * $base * $height;
    }

}

I could use the child's __construct() methods to set the properties of the different shapes at the initiation time but I'd like to know if another way exists and allows me to define variable list of parameters.

Thanks in advance.

Upvotes: 1

Views: 1951

Answers (2)

Marcel
Marcel

Reputation: 5119

As in the comments under your question mentioned, there are several ways to solve your issue.

Class properties and the constructor That would be the easiest approach in my opinion. It 's easy and smart.

interface Shape
{
    protected function getShape();
}

class Square implements Shape
{
    protected $length;

    public function __construct(int $length)
    {
        $this->length = $length;
    }

    protected function shape()
    {
        return pow($this->length, 2);
    }
}

class Triangle implements Shape
{
    protected $base;

    protected $height;

    public function __construct(int $base, int $height)
    {
        $this->base = $base;
        $this->height = $height;
    }

    protected function getShape()
    {
        return .5 * $this->base * $this->height;
    }
}

Every class implements the Shape interface. The getShape method got no attributes. The attributes are protected properties of the class itself. You set these properties when calling the constructor of the specific class.

Upvotes: 2

nerdlyist
nerdlyist

Reputation: 2857

I think how the idea to use the __construct is the best approach really. It is what that is for. You want each shape to be different and each shape has to calculate area differently. Hence polymorphism and OOP design principles.

With that said yes there are always other hacks. I do not recommend this approach but you can use it if wanted. Essentially pass in an array with keys for the pieces you want and use them.

abstract class Shape {
    abstract protected function getArea($data = null); //Default to null incase it is not passed.
}

class Square extends Shape {

    public function getArea($data) //$data should have a length key
    {
        if(isset($data)){
            return pow($data['length'], 2);
        }
    }

}

class Triangle extends Shape {

    public function getArea($data) //$data should have a base and height key
    {
        if(isset($data)){
            return .5 * $data['base'] * $data['height'];
        }
    }

}

Upvotes: 1

Related Questions