CODEWITHSUNDEEP
jpaspring-bootone-to-many
Rares
Rares

Reputation: 637

StackoverflowError JPA in OneToMany relationship

So I have 2 classes: Game and User. User can play 1 or more games so it'a a OneToMany relationship between them. Here are the classes.

And I try to make the relationship bidirectional between classes.

Game:

@Entity
public class Game {
    @Id
    @Column(name = "GAME_NUMBER")
    @GeneratedValue(strategy = GenerationType.SEQUENCE)
    private long gameNumber;

    private int playerScore;
    private int NPCScore;
    private Date datetime;

    @ManyToOne
    @JoinColumn(name="USER_ID")
    private User user;

    public Game() {}

    public Game(int playerScore, int nPCScore, Date datetime) {
        super();
        this.playerScore = playerScore;
        this.NPCScore = nPCScore;
        this.datetime = datetime;
    }

    public User getUser() {
        return user;
    }
} + getters & setters for attributes

User:

@Entity
public class User {
    @Id
    @Column(name = "USER_ID")
    @GeneratedValue(strategy = GenerationType.SEQUENCE)
    private long userId;

    private String username;
    private String password;

    @OneToMany(mappedBy="user",cascade=CascadeType.ALL)
    private List<Game> games;

    @ElementCollection
    private List<Date> startSessions;

    public User() {}

    public User(String username, String password, List<Game> games, List<Date> startSessions) {
        super();
        this.username = username;
        this.password = password;
        this.games = games;
        this.startSessions = startSessions;
    }
}

So when the user plays a new game the below method finds the user in database(hsqldb) and we add the new game to the List. Because the relationship is bidirectional I set the user to each Game played ...so this is what causing the problem. Can I fix in some other way?

@RequestMapping(value = "/game/play", method = RequestMethod.POST)
@ResponseBody
public User indexRequestPlay(@RequestParam String username, @RequestParam String password) {

    User user = userRepository.findByUsernameAndPassword(username, password);

    Random random = new Random();
    int userScore = random.nextInt(5) + 1;
    int npcScore = random.nextInt(5) + 1;
    Date date = new Date();

    List<Date> startSessions = user.getStartSessions();
    startSessions.add(date);
    user.setStartSessions(startSessions);

    Game game = new Game(userScore, npcScore, date);
    game.setUser(user);
    List<Game> games = new ArrayList<Game>();
    games.addAll(user.getGames());
    games.add(game);
    user.setGames(games);

    userRepository.save(user);
    return user;
}

I am receiving this errors: 

java.lang.IllegalStateException: Cannot call sendError() after the response has been committed

and stackoverflowerror

Upvotes: 9

Views: 9909

Answers (1)

Rares
Rares

Reputation: 637

I figured it out that the JSON was the problem..... I got Infinite Recursion with the JSON. I added this @JsonManagedReference and @JsonBackReference. and fixed the problem. You can check the full answer here. Thx!

https://stackoverflow.com/a/18288939/7947794

Upvotes: 14

Related Questions