CODEWITHSUNDEEP
iosswiftswift-playgroundswift4
J. Doe
J. Doe

Reputation: 693

Declarations in extensions cannot override yet error in Swift 4

I have an extension:

public extension UIWindow {
    override public func topMostController()->UIViewController? { ... }
}

but for my topMostController I get the next error:

Declarations in extensions cannot override yet error

It works well for Swift 3.1, but for Swift 4 I get this error. How can it be fixed? What did they change in Swift 4?

Upvotes: 65

Views: 31311

Answers (3)

nahung89
nahung89

Reputation: 8105

Swift 5

Actually there are few problems in OP code:

  1. UIView (which is superclass of UIWindow) doesn't have method topMostController(), that why you can't override it.

  2. Apple doesn't encourage override func inside extension:

    Extensions can add new functionality to a type, but they cannot override existing functionality.

  3. Incase you still want to override function in extension, there are 2 ways:

[A] Mark your function with @objc dynamic func in parent class:

class Vehicle {
    @objc dynamic func run() { /* do something */ }
}

class Car: Vehicle { }

extension Car {
    override func run() { /* do another thing */ }
}

[B] Override function from build-in classes, which is descendant of NSObject.

 extension UIWindow {
    // UIWindow is a descendant of NSObject, and its superclass UIView has this function then you can override
    override open func becomeFirstResponder() -> Bool {
        ...
        return super.becomeFirstResponder()
    }
 }

Upvotes: 3

Sulthan
Sulthan

Reputation: 130162

It will work if you make the base implementation @objc. See Hamish's answer for a detailed explanation about the internals.

Overriding methods declared in extensions is a bit tricky to do correctly. Objective-C supports it, but it's not absolutely safe. Swift aims to do it better. The proposal is not completed yet.

Current version of the proposal available here.

Upvotes: 67

Nikhlesh Bagdiya
Nikhlesh Bagdiya

Reputation: 4466

Extensions can add new functionality to a type, but they cannot override existing functionality.

Extensions add new functionality to an existing class, structure, enumeration, or protocol type. This includes the ability to extend types for which you do not have access to the original source code (known as retroactive modeling).

Extensions in Swift can:

  • Add computed instance properties and computed type properties
  • Define instance methods and type methods
  • Provide new initializers
  • Define subscripts
  • Define and use new nested types
  • Make an existing type conform to a protocol

Apple Developer Guide

You are trying to do is similar to what done by this code:

class MyClass: UIWindow {
    func myFunc() {}
}

extension MyClass {
    override func myFunc() {}
}

NOTE: If you want to override topMostController() then make subclass of UIWindow

Upvotes: 12

Related Questions