CODEWITHSUNDEEP
.netinotifypropertychanged
KyleLib
KyleLib

Reputation: 794

Pattern for implementing INotifyPropertyChanged?

I have seen the following pattern used for implementing INotifyPropertyChanged

private void NotifyPropertyChanged(string propertyName)
{
    PropertyChangedEventHandler handler = PropertyChanged;
    if (handler != null)
    {
        handler(this, new PropertyChangedEventArgs(propertyName));
    }
}

public event PropertyChangedEventHandler PropertyChanged;

Can someone explain to me the necessity of the var handler = PropertyChanged assignment prior to checking it for null versus directly checking PropertyChanged == null directly?

Thanks

Upvotes: 7

Views: 2212

Answers (3)

Thomas Levesque
Thomas Levesque

Reputation: 292725

Eric Lippert explains this in details in this blog article: Events and races.

Basically, the idea is to avoid a race condition in case another thread unsubscribes the last handler for this event after you check PropertyChanged != null, but before you actually invoke PropertyChanged. If you make a local copy of the handler, this cannot happen (but you might end up calling a handler that's just been unsubscribed)

Upvotes: 4

James Hay
James Hay

Reputation: 12720

It's the thread safe method of raising events. By assigning the publicly accessible PropertyChanged event locally before using it you ensure that it won't be different between the 'if' statement and the line actually raising the event.

Upvotes: 1

John Sloper
John Sloper

Reputation: 1821

In a multi-threaded world, the PropertyChanged may be set to null after the if statement has been evaluated.

Upvotes: 0

Related Questions