CODEWITHSUNDEEP
javascriptnode.jsmongodb
Sarbjyot Singh Chahal
Sarbjyot Singh Chahal

Reputation: 551

Error: data and salt arguments required

I am trying to save a user to mongodb database using post request as follow, but I got the error bcrypt Error: data and hash arguments required .It's a pretty simple set up of the code but i can't figure out anything wrong with it. models/users.js 

const mongoose = require('mongoose');
const bcrypt = require('bcrypt');
const confic = require('../models/users');

// User schema
const UserSchema = mongoose.Schema({
	name: {
		type: String,
	},
	email: {
		type: String,
		required: true
	},
	username:{
		type: String,
		required: true
	},
	password: {
		type: String,
		required: true
	}
});

const User = module.exports = mongoose.model('User', UserSchema);

module.exports.getUserById = function(id,callback){
	User.findById(id,callback);
}

module.exports.getUserByUsername = function(username,callback){
	const query = {username:username}
	User.findOne(query,callback);
}

module.exports.addUser= function (newUser, callback) {
   bcrypt.genSalt(10,(err,salt) => {
   	bcrypt.hash(newUser.password, salt , (err, hash) =>{
        if(err) throw (err);

        newUser.password=hash;
        newUser.save(callback);
   	});
   });
}
routes/users.js

const jwt = require('jsonwebtoken');
User = require('../models/users')

// // Register
router.post('/register', (req, res, next) => {
  var newUser = new User({
    name: req.body.name,
    email: req.body.email,
    username: req.body.username,
    password: req.body.password
  });

  User.addUser(newUser, (err, User) => {
    if(err){
      // res.json({success: false, msg:'Failed to register user'});
    } else {
      // res.json({success: true, msg:'User registered'});
    }

  });

});

// Authenticate
router.post('/authenticate', (req, res, next) => {
  res.send('AUTHENTICATE');
});

// Profile
router.get('/profile', (req, res, next) => {
  res.send('PROFILE');
});

module.exports = router;
Server was running but after using postman chrome post request error are shown and server stop working as errors shown in image.enter image description here

Upvotes: 35

Views: 97019

Answers (8)

profCodey
profCodey

Reputation: 1

If you use Express, installing the "body-parser" middleware fixes the problem. Install it with this command:

npm i body-parser

Then configure Express to use the middleware.

const bodyparser = require("body-parser");
app.use(bodyparser.urlencoded({ extended: false }));
app.use(bodyparser.json());

More information:

Upvotes: 0

user22181170
user22181170

Reputation: 1

it seems like the password argument you passed isn't defined. I know the req.body.password is supposed to generate the user password, but for some reasons it doesn't work that way. Instead try this

 bcrypt.genSalt(10,(err,salt) => {
    bcrypt.hash(`${password}`, salt , (err, hash) =>{
        if(err) throw (err)

What i did was simply use the iterals in passing the password arguments.

Upvotes: 0

Tharindu Lakshan
Tharindu Lakshan

Reputation: 1

Error: data and salt arguments required

{
    "email": "[email protected]",
    "passsword": "djhsd@92129nnj!"
}

It's likely that the password field is not being passed correctly in the request payload. Your code example provides valuable insight into how to properly validate the email and password inputs before attempting to use them.

Sometimes your Postman API checking to go to incorrectly or something this error overcome another wish this error comes from, It looks like your salt is correctly generated and you didn't check newUser.password === undefined

Here example code snippet,

if (!email || typeof email !== "string") {
    throw Error("Email is required");
}

//valide password
if (!password || typeof password !== "string") {
    throw Error("Password is required");
}

//valide email format
if (!validator.isEmail(email)) {
    throw Error("Email is not valid");
}

//valide password length
if (!validator.isLength(password, { min: 6 })) {
    throw Error("Password must be at least 6 characters");
}

Upvotes: 0

Riyaz Roshan
Riyaz Roshan

Reputation: 11

When I was testing with plain text mode, I got this error (data and salt argument required), once I did change to json, it was ok.

Upvotes: 1

boehm_s
boehm_s

Reputation: 5564

The error comes from the bcrypt.hash method. In your case, you have the following piece of code :

bcrypt.hash(newUser.password, salt , (err, hash) => { ... }

I think that your problem comes from the newUser.password that must be empty (null or undefined). The error says data and salt arguments required. It looks like your salt is correctly generated and you didn't check if newUser.password === undefined, so here's my bet: somehow newUser.password is undefined.

Also, you can check if the genSalt method works fine by adding if(err) throw (err); after calling it as you did for the bcrypt.hash method.

Upvotes: 66

Jamshaid K.
Jamshaid K.

Reputation: 4587

Make sure the properties are as they are being supplied, in my case, I was sending a Password property with a capital P and then passing the password with a small p letter to the hash function.

Upvotes: 2

user11586294
user11586294

Reputation:

Per mongoose docs: https://mongoosejs.com/docs/faq.html

Q. I'm using an arrow function for a virtual, middleware, getter/setter, or method and the value of this is wrong.

A. Arrow functions handle the this keyword much differently than conventional functions. Mongoose getters/setters depend on this to give you access to the document that you're writing to, but this functionality does not work with arrow functions. Do not use arrow functions for mongoose getters/setters unless do not intend to access the document in the getter/setter.

Upvotes: 1

Imran Hussain
Imran Hussain

Reputation: 160

Remove the arrow => in bcrypt.hash() . Use old fashioned method definition function() {}

Upvotes: 2

Related Questions