CODEWITHSUNDEEP
javaloopsreplace
joao-m-santos
joao-m-santos

Reputation: 187

Java: Issue when replacing Strings on loop

I'm building a small app which auto translates boolean queries in Java.

This is the code to find if the query string contains a certain word and if so, it replaces it with the translated value.

int howmanytimes = originalValues.size();

for (int y = 0; y < howmanytimes; y++) {
    String originalWord = originalValues.get(y);
    System.out.println("original Word = " + originalWord);

    if (toReplace.contains(" " + originalWord.toLowerCase() + " ") 
         || toCheck.contains('"' + originalWord.toLowerCase() + '"')) {
        toReplace = toReplace.replace(originalWord, translatedValues.get(y).toLowerCase());
        System.out.println("replaced " + originalWord + " with " + translatedValues.get(y).toLowerCase());
    }

    System.out.println("to Replace inside loop " + toReplace);
}

The problem is when a query has, for example, '(mykeyword OR "blue mykeyword")' and the translated values are different, for example, mykeyword translates to elpalavra and "blue mykeyword" translates to "elpalavra azul". What happens in this case is that the result string will be '(elpalavra OR "blue elpalavra")' when it should be '(elpalavra OR "elpalavra azul")' . I understand that in the first loop it replaces all keywords and in the second it no longer contains the original value it should for translation. How can I fix this?

Thank you

Upvotes: 0

Views: 375

Answers (2)

albert_nil
albert_nil

Reputation: 1658

The "toCheck" variable is not explained what is for, and in any case the way it is used looks weird (to me at least).

Keeping that aside, one way to answer your request could be this (based only on the requirements you specified):

  1. sort your originalValues, so that the ones with more words are first. The ones that have same number of words, should be ordered from more length to less.

Upvotes: 0

Serge-Zh
Serge-Zh

Reputation: 26

you can sort originalValues by size desc. And after that loop through them. This way you first replace "blue mykeyword" and only after you replace "mykeyword"

Upvotes: 1

Related Questions