ModelState.IsValid Return False Even There is No Error Why?

Question

I read many of the questions about if(ModelState.IsValid) returns false with error, I also tried this code:

var errors = ModelState.Values.SelectMany(v => v.Errors);

to find what error but it shows no error in it. But if(ModelState.Isvalid) returns always false. I don't known what mistake I've done in Model, Controller or View.

Model:

public class AdminSignup
{
    [Required(ErrorMessage="Contact Person is Required",AllowEmptyStrings=false)]
    public string ContactPerson { get; set; }
   
    [Required(ErrorMessage="Email Id is Required",AllowEmptyStrings=false)]
    public string EmailId { get; set; }

    [Required(ErrorMessage="User Name is Required",AllowEmptyStrings=false)]
    public string UserName { get; set; }

    [Required(ErrorMessage="Password is Required",AllowEmptyStrings=false)]
    public string Password { get; set; }

    [Required(ErrorMessage="Apartment Name is Required",AllowEmptyStrings=false)]
    public string ApartmentName { get; set; }

    [Required(ErrorMessage="Location/City is Required",AllowEmptyStrings=false)]
    public string LocationCity { get; set; }

    [Required(ErrorMessage="Apartment Address is Required",AllowEmptyStrings=false)]
    public string ApartmentAddress { get; set; }

    [Required(ErrorMessage="Apartment PhoneNumber is Required",AllowEmptyStrings=false)]
    public string ApartmentPhoneNumber { get; set; }

    [Required(ErrorMessage="NoOfUnits is Required",AllowEmptyStrings=false)]
    public string NoOfUnits { get; set; }     
}

Controller:

[HttpPost]        
public ActionResult signup(AdminSignup asign)
{
    if ( ModelState.IsValid)
    {                           
        //SqlConnection con = new SqlConnection(connString);
        //con.Open();
        //SqlCommand cmd = new SqlCommand("Insert into AdminSignup (ApartmentName,ContactPerson,LocationCity,ApartmentAddress,ApartmentPhoneNumber,EmailId,NoOfUnits)  values('" + asign.ApartmentName + "','" + asign.ContactPerson + "','" + asign.LocationCity + "','" + asign.ApartmentAddress + "','" + asign.ApartmentPhoneNumber + "','" + asign.EmailId + "','" + asign.NoOfUnits + "')", con);
        //cmd.ExecuteNonQuery();

        //AdminSignup adminsignup = new AdminSignup
        //{
        //    EmailId = asign.EmailId
        //};

        //TempData["EmailId"] = adminsignup;

        //con.Close();
        return RedirectToAction("SignupStep2");
    }
    return View();    
}

And View :

@using (Html.BeginForm("signup", "Apartment", FormMethod.Post, new { @class = "form-horizontal", @Id = "first-form" }))
{
  //@Html.ValidationSummary(false)
  
    
      Apartment Name   ^*
      
        @* *@
        @Html.TextBoxFor(m => m.ApartmentName, new {@class="form-control",@Id="ApartmentName",placeholder="Apartment Name" })   
        @Html.ValidationMessageFor(m=>m.ApartmentName)                           
      
    
    
      Contact Person   ^*
      
        @**@
        @Html.TextBoxFor(m => m.ContactPerson, new {@class="form-control",@Id="ContactPerson",placeholder="Contact Person" })
        @Html.ValidationMessageFor(m=>m.ContactPerson)
      
                
    
      Location / City   ^*
      
        @* *@
        @Html.TextBoxFor(m => m.LocationCity, new {@class="form-control",@Id="LocationCity",placeholder="Location/City" })
        @Html.ValidationMessageFor(m=>m.LocationCity)
      
    
    
      Apartment Address   ^*
      
        @*Apartment Address*@
        @Html.TextAreaFor(m => m.ApartmentAddress, new {@class="form-control",@Id="ApartmentAddress" ,placeholder="Apartment Address" })
        @Html.ValidationMessageFor(m=>m.ApartmentAddress)
      
    
    
      Apartment PhoneNumber   ^*
      
        @**@
        @Html.TextBoxFor(m => m.ApartmentPhoneNumber, new {@class="form-control",@Id="ApartmentPhoneNumber",placeholder="Apartment PhoneNumber" })
        @Html.ValidationMessageFor(m=>m.ApartmentPhoneNumber)
      
    
    
      Email Id   ^*
      
        @Html.TextBoxFor(m => m.EmailId, new {@class="form-control",@Id="Email Id",placeholder="EmailId" })
        @Html.ValidationMessageFor(m=>m.EmailId)
      
    
    
      No of Units   ^*
      
        @**@
        @Html.TextBoxFor(m => m.NoOfUnits, new {@class="form-control",@Id="NoOfUnits",placeholder="No.Of.Units" })
        @Html.ValidationMessageFor(m=>m.NoOfUnits)

Masoud Andalibi · Accepted Answer

Look at your view and model again, you have put required on all your properties within the class, however you are returning 7 of 9 properties. then Model.IsValid will look at your Model and see oh look there 2 required properties that you are not returning, so it will be false. either remove [required] on those properties or add them within your view. good luck.

Update Those 2 Properties are:

UserName And Password, they need to be within your Html.BeginForm, so they will be send to server as the part of your class.

ModelState.IsValid Return False Even There is No Error Why?

Answers (1)

Related Questions