CODEWITHSUNDEEP
c#emailsmtpclient
Shakti S
Shakti S

Reputation: 21

how to send email using smtp in c#?

I have a list of data from a database and I have Email Id's in database, i have to send email to those ID's where if its retention date is tomorrow means i have to send an intimation email as reminder by today,i want to send email, and i will use service to send it daily, but my email part is not working..below is my code..

using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Mail;
using System.Text;
using System.Threading.Tasks;


namespace SendingEmail
{
    public class SendingMail
    {
      public static void SendMail(string recipient, string subject, string 
      body, string attachmentFilename)
        {
           //method to send email 
           MailMessage mail = new MailMessage();
            try
            {
                SmtpClient SmtpServer = new SmtpClient("smtp.gmail.com", 587);
                SmtpServer.EnableSsl = true;
                SmtpServer.Credentials = new System.Net.NetworkCredential("[email protected]", "my password");
                string From = "my [email protected]";
                string To = "email.com";
                mail.Subject = "Test Mail - 1";
                mail.Body = "mail with attachment";
                MailMessage msg = new MailMessage(From, To);
                System.Net.Mail.Attachment attachment;
                attachment = new System.Net.Mail.Attachment
                (@"C:\Users\rahul.chakrabarty\Desktop\logg.txt");
                mail.Attachments.Add(attachment);
                SmtpServer.Send(mail);
            }
            //To cathch Exception
            catch (Exception ex)
            {
                Console.WriteLine("unable to send" + ex);
            }
        }
    }
}

My error is "unable to sendsystem.InvalidOperationException: A from address must be specified"..This is my error

Upvotes: 0

Views: 373

Answers (1)

Caius Jard
Caius Jard

Reputation: 74700

You said

String from = "my email@gmail...

But nowhere have you actually assigned this string to the mail.From property - you've gone and made a new MailMessage using that from address, and called it msg:

MailMessage msg = new MailMessage(From, To)

but you aren't sending the msg mail, you're sending the mail mail:

SmtpServer.Send(mail);

The same problem exists with the To address on the mail variable

Basically, the code is all messed up: you make TWO MailMessage objects, set half the necessary things on one, the other half of necessary things on the other, and then try to send one of them with incomplete details. It's kinda like you copied and pasted two different tutorials together but didn't get enough of either of them to get a complete MailMessage ready for sending

I could have fixed this all up for you and posted working code, but I haven't for two reasons: 1) it's very easy to do these small changes yourself, and 2) I want YOU to do it as a learning exercise rather than just giving you the answer :)

Make sure you don't put a space in the email address either

Upvotes: 1

Related Questions