CODEWITHSUNDEEP
angulartypescriptionic-frameworkionic2ionic3
Skel
Skel

Reputation: 1667

Ionic Storage returning undefined the first time

I have a storage set to access_token and when i get it to return the first time i fails

PROVIDER:

getLayMinisters(){
   console.log(this.access_token);
   return this.http.get(
     this.api.url() + '/faith-leader/' + 'lay-ministers',
     {
       headers: new Headers({ "Authorization": "Bearer " + this.access_token })
     }
   )
   .map(
     response => response.json()
   );
}

This is the constructor for this file

access_token: any;
layMinister_id: string;

constructor(
    public http: Http,
    public storage: Storage,
    public api: ApiProvider
) {
    this.storage.get('access_token').then(
      (access_token) => {
        this.access_token = access_token;
      }
    )
  }

This is in my page

getLayMinisters(){
    this.layMinisterProvider.getLayMinisters().subscribe(
      data => {
        this.layMinisters = data;
      }
    );
}

This is above it

layMinisters = [];

constructor(
    public navCtrl: NavController, 
    public navParams: NavParams,
    public layMinisterProvider: LayMinisterProvider,
    public alertCtrl: AlertController
) {}

ionViewDidLoad() {
    this.getLayMinisters();
}
ionViewWillEnter() {
    // this.getLayMinisters();
}

When the page first runs it return the console.log(this.access_token) returns as undefined and then i get the error of the api not responding. But when i click on the link again to open the page it runs it fine and prints the access_token and runs the api call and prints all the data

Upvotes: 0

Views: 1430

Answers (1)

Sergio Escudero
Sergio Escudero

Reputation: 1894

When you call getLayMinisters() the access_token is undefined because these task are asynchronous, so when you do http.get probably this.storage.get() is not finished because It's a promise, if you code in http.get function

setTimeout(()=>{
  console.log(this.access_token)
},1000)

Maybe with 1000ms probably will print it (it depends of the storage.get() promise response time).

To solved it you can create a function in layMinisterProvider:

getToken(){
    return this.storage.get('access_token')
}

and in the page: 

getLayMinisters() {
    if(!this.layMinisterProvider.access_token){
        this.layMinisterProvider
        .getToken()
        .then((access_token) => {
            this.layMinisterProvider.access_token = access_token;
            this.getData();
        })
    }else{
        this.getData();
    }
}
getData(){
    this.layMinisterProvider
                .getLayMinisters()
                .subscribe(data => {
                    this.layMinisters = data;
                });
}

Remember the provider must has access_token as public.

Upvotes: 1

Related Questions