CODEWITHSUNDEEP
c#jsonequals
Adibe7
Adibe7

Reputation: 3539

Comparing C# objects using Json

I want to compare two objects without implementing the Equals() method.

What are the downsides of comparing them in this way: 1. serilizing them with Json 2. comparing the results

thanks!

Upvotes: 4

Views: 4833

Answers (4)

Coconut
Coconut

Reputation: 131

Maybe with a class like that you can do the work (BsonDocument is a class from MongoDBDriver):

    public class Comparer
    {
        private object first, second;

        public Comparer(object first, object second)
        {
            this.first = first;
            this.second = second;
        }

        public List<string> Compare()
        {
            if (first.GetType() != second.GetType())
            {
                return null;
            }

            BsonDocument firstDoc = first.ToBsonDocument();
            BsonDocument secondDoc = second.ToBsonDocument();

            return Compare(firstDoc, secondDoc);
        }

        private List<string> Compare(BsonDocument first, BsonDocument second)
        {
            List<string> changedFields = new List<string>();

            foreach (string elementName in first.Names)
            {
                BsonElement element = first.GetElement(elementName);

                if (element.Value.IsBsonDocument)
                {
                    BsonDocument elementDocument = element.Value.AsBsonDocument;

                    BsonDocument secondElementDocument =
                        second.GetElement(element.Name).Value.AsBsonDocument;

                    if (elementDocument.ElementCount > 1 &&
                        secondElementDocument.ElementCount ==
                        elementDocument.ElementCount)
                    {
                        foreach (string value in (Compare(elementDocument,
                                                       secondElementDocument)))
                        {
                            changedFields.Add(value);
                        }
                    }

                    else
                    {
                        changedFields.Add(element.Name);
                    }
                }

                else if (element.Value != second.GetElement(element.Name).Value)
                    changedFields.Add(element.Name);
            }

            return changedFields;
        }
}

Upvotes: 1

JamesEggers
JamesEggers

Reputation: 12936

There is some overhead to the serialization process to convert objects to json. You'd have to test to see if the overhead is acceptable for your situation.

That aside, the source of the json object is a concern. I've seen a couple different json serializers format objects differently (e.g. quoting property names vs. not quoting them). Things like this could yield you untrue results.

Upvotes: 2

Oded
Oded

Reputation: 499382

The downside is that you need to serialize them, which is potentially slow, and definitely slower than implementing Equals.

You may also end up with part of the objects that you need to compare not being seriazlied and therefore not getting true comparison.

Upvotes: 3

jjnguy
jjnguy

Reputation: 138982

What are the downsides of comparing them in this way

Loss of speed. Transforming objects into JSON strings and then comparing them is much slower than doing a property by property equals.

Implementing Equals() is always the best way to compare two objects for equality.

Upvotes: 9

Related Questions