Doug Smith
Doug Smith

Reputation: 580

Django How to pass object id via form action?

I'm still having problems passing an object's id in the url of a form.

adjust.html

<form action="{% url 'classroom:deleteblock' classroom.id %}" method="post">
    {% csrf_token %}
    {{ form }}
<input type="submit" value="submit" />
</form>

models.py

class Classroom(models.Model):
    COURSE_NAME = (
        ('MA8', 'Math 8'),
        ('SC10', 'Science 10'),
        ('PH11', 'Physics 11'),
        ('PH12', 'Physics 12'),
    )
    BLOCK_NUMBER = (
        ('11', 'Block 1-1'),
        ('12', 'Block 1-2'),
        ('13', 'Block 1-3'),
        ('14', 'Block 1-4'),
        ('21', 'Block 2-1'),
        ('22', 'Block 2-2'),
        ('23', 'Block 2-3'),
        ('24', 'Block 2-4'),
    )
    class_list = models.TextField()
    course_name = models.CharField(max_length=20, choices=COURSE_NAME)
    course_block = models.CharField(max_length=10, choices=BLOCK_NUMBER)
    group_size = models.IntegerField(default=3)

    def __str__(self):
        return self.get_course_block_display()

    def save(self, *args, **kwargs):
        super(Classroom, self).save(*args, **kwargs)
        # overrides the default save function to parse the class list
        studentList = []
        studentList = self.class_list.split('\n')
        print (studentList)
        for line in studentList:
            line = line.strip('\r')
            s = Student.objects.create(nickname = line, classroom = self)

class DeleteForm(ModelForm):
    class Meta:
        model = Classroom
        fields = ['course_block']

views.py

class BlockDeleteView(DeleteView):
    model = Classroom

delete_block_view = BlockDeleteView.as_view()

def adjust(request):
    if request.method == 'POST':
        form = DeleteForm(request.POST)
        if form.is_valid():
            return render(request, 'classroom/adjust.html')
    else:
        form = DeleteForm()

    return render(request, 'classroom/adjust.html', {'form': form})

urls.py

urlpatterns = [
    url(r'^$', views.index, name='index'),
    url(r'^submitted', views.submitted, name='submitted'),
    url(r'^classup/$', create_classroom_view, name='classroom'),
    url(r'^block/$', views.block, name='block'),
    url(r'^(?P<pk>[09-]+)/deleteblock/$', delete_block_view, name='deleteblock'),
    url(r'^adjust/$', views.adjust, name='adjust'),
    url(r'^random/$', list_random_view, name='random'),
]

So the idea is that adjust.html gives me a form with one choice drop down menu corresponding to course_block. I choose the course, click submit, and hopefully I'm redirected to classroom_form.html. The action of the form is to send the object pk to DeleteView which I think is supposed to delete the object.

Running as above, I get an error: Reverse for 'deleteblock' with arguments '('',)' not found. 1 pattern(s) tried: ['classroom/(?P<pk>[09-]+)/deleteblock/$']. How do a correctly pass the action url to match deleteblock?

I guess I'll find out soon, but do I need a get_url_success() in my BlockDeleteView?

EDIT: I've also tried passing a query to the template in the context but have the same error. views.py

def adjust(request):
    classroom = Classroom.objects.all().first()
    if request.method == 'POST':
        form = DeleteForm(request.POST)
        if form.is_valid():
            return render(request, 'classroom/adjust.html', {'form':form}, {'classroom':classroom})
    else:
        form = DeleteForm()

    return render(request, 'classroom/adjust.html', {'form': form}, {'classroom': classroom})

Upvotes: 2

Views: 3579

Answers (3)

Ykh
Ykh

Reputation: 7717

url(r'^(?P<pk>[0-9]+)/deleteblock/$', delete_block_view, name='deleteblock'),

[0-9]+ not [09-]+, and you need a success_url or get_url_success() method in BlockDeleteView

change your views.py:

class BlockDeleteView(DeleteView):
    model = Classroom
    slug_field = 'id'
    success_url = reverse_lazy('some_url')
    template_name = 'classroom/delete.html'

urls.py

url(r'^(?P<pk>[0-9]+)/deleteblock/$', BlockDeleteView.as_view(), name='deleteblock'),

Upvotes: 2

pvkcse
pvkcse

Reputation: 99

I think it should be 0-9 and not 09- , used at the regex(regular expression) part of the url_mapping for the deleteblock at url_patterns.

Try this:

url(r'^(?P<pk>[0-9]+)/deleteblock/$', delete_block_view, name='deleteblock')

Instead of this:

url(r'^(?P<pk>[09-]+)/deleteblock/$', delete_block_view, name='deleteblock')

Upvotes: 1

Mauricio Cortazar
Mauricio Cortazar

Reputation: 4213

classroom.id doesn't exist, you must pass that var in the context and in the url you have to be specific should be {% url 'classroom:deleteblock' pk=classroom.id %}

Upvotes: 0

Related Questions