CODEWITHSUNDEEP
javasqloracle-database
John Kyle
John Kyle

Reputation: 125

SQL command not properly ended update

When I try to execute the script below on Java I've got this exception :

SQL command not properly ended

I am using Java Swing and Oracle SQL

My string:

String sql= "update PROJEKT.PACJENT set IMIE='"+ jTextField9.getText() + "',NAZWISKO='"+ jTextField10.getText() + "',MIASTO='"+ jTextField11.getText() + "',ULICA='"+ jTextField12.getText() + "',UBEZPIECZENIE=" + jTextField13.getText() + "' where PESEL='" + jTextField8.getText()+ "'";

Upvotes: 0

Views: 151

Answers (2)

romanvintonyak
romanvintonyak

Reputation: 351

Something like this should work for you:

String updateSQL = "update PROJEKT.PACJENT set IMIE=?, NAZWISKO=?, MIASTO=?, ULICA=?, UBEZPIECZENIE=? where PESEL=?";
PreparedStatement preparedStatement = dbConnection.prepareStatement(updateSQL);
preparedStatement.setString(1, jTextField9.getText());
preparedStatement.setString(2, jTextField10.getText());
preparedStatement.setString(3, jTextField11.getText());
preparedStatement.setString(4, jTextField12.getText());
preparedStatement.setString(5, jTextField13.getText());
preparedStatement.setString(6, jTextField8.getText());
preparedStatement.executeUpdate();

Upvotes: 3

Ravi
Ravi

Reputation: 31417

Because, you missed open ' quote

UBEZPIECZENIE=" + jTextField13.getText() + "'

Also, you should use PreparedStatement to avoid SQL injection.

Upvotes: 6

Related Questions