Replace current JScrollPane to another JScrollPane in JPanel

Question

I would like to change my current JScrollpane to a new one. I would like it to change after I pressed my button and the method actionPerformed is called. The problem I currently have is that it only paints the Jscroll at the beginning of the application, when i want to change it, it dosent work.(When the application is running).

What I do is: In the beginning of the application I make a new JscrollPane and this one is empty. If the button is pressed: Show another JscrollPane with content.

if(btnPressed == true){

//set current empty jscroll pane to a filled one.
jscrollpane = View.createScrollPlane();


//View.createScrollPlane = This method fills the JscrollPane with text.
}
else { //show a empty one
 jscrollpane = new JscrollPane();

}

I have tried: - remove - add - revalidate - repaint

And also: JscrollPane.setViewPortView(JscrollPane);

I've looked to CardLayout but I would rather not and it dosent allow me since only empty containers can be changed to CardLayout. Currently its on GridBagLayout.

Thanks in advance

RE-edit: the Create-UI method dosent change the current empty Jscrollpanel to the new one. It only initialise it once (at the beginning) but dosent update the Jscroll panel. (when i tried to put it on false) it worked, the boolean did change to true but dosent update the jscroll panel.

package readDataPluginPackage;

import com.change_vision.jude.api.inf.AstahAPI;
import com.change_vision.jude.api.inf.project.ProjectAccessor;
import javafx.embed.swing.JFXPanel;

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import java.beans.PropertyChangeListener;

public class Application {
    JPanel mainJPanel;
    private JPanel leftJPanel;
    private JPanel rightJPanel;
    private JButton btnSynchronise;
    private JButton btnPreview;
    private JScrollPane JScrollPaneReport;
    public JScrollPane JScrollPanePreview;
    private boolean btnPreviewClicked = false;

    public Application() {
        $$$setupUI$$$();

        btnPreview.addActionListener(new ActionListener() {
            @Override
            public void actionPerformed(ActionEvent e) {
                btnPreviewClicked = true;



                JOptionPane.showMessageDialog(null, "Showing..." + btnPreviewClicked);


                //   ShowXMLFileView showXMLFileView = new ShowXMLFileView();
                //     JScrollPanePreview = showXMLFileView.createLabelPane();

                //   if (btnPreview.isEnabled()) {
                //  ShowXMLFileView showXMLFileView = new ShowXMLFileView();
                // JScrollPanePreview = showXMLFileView.createLabelPane();
                JOptionPane.showMessageDialog(null, "XML File Preview has been  updated.");


               createUIComponents();
                //   JScrollPanePreview.revalidate();
                // JScrollPanePreview.repaint();
                JOptionPane.showMessageDialog(null, "Components are created again.");

            }


            //  }


        });
        btnSynchronise.addActionListener(new ActionListener() {
            @Override
            public void actionPerformed(ActionEvent e) {
                JOptionPane.showMessageDialog(null, "Synchronising...");
            }
        });


    }


    public static void main(String[] args) {
        try {

            //Save Astah Project as XML File
            ProjectAccessor prjAccessor = AstahAPI.getAstahAPI().getProjectAccessor();
            prjAccessor.open("C:\\Users\\delina\\generated\\test.asta");
            prjAccessor.exportXMI("C:\\Users\\delina\\generatedXMI\\temp.xml");
            prjAccessor.close();

            //Show the most recent version of the xml file of the Astah Project
            ReadXMLFile rd = new ReadXMLFile();
            rd.showXMLFileLines();

        } catch (Exception e) {
            e.printStackTrace();
        }


        JFrame frame = new JFrame("Application");
        frame.setContentPane(new Application().mainJPanel);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.pack();
        frame.setVisible(true);
    }

    private void createUIComponents() {
        if (btnPreviewClicked == true) {


       //  ShowXMLFileView showXMLFileView = new ShowXMLFileView();
          // JScrollPanePreview = showXMLFileView.createLabelPane();
                 //  JScrollPanePreview.setViewportView(JScrollPanePreview);







            leftJPanel.remove(JScrollPanePreview);

            ShowXMLFileView showXMLFileView = new ShowXMLFileView();
            JScrollPane JScrollPanePreview = showXMLFileView.createLabelPane();


            leftJPanel.add(JScrollPanePreview);
        JScrollPanePreview.revalidate();
        JScrollPanePreview.repaint();







       JOptionPane.showMessageDialog(null, "JScrollPanel changed");
     } else {
            JScrollPanePreview = new JScrollPane();
     }


    }


    /**
     * Method generated by IntelliJ IDEA GUI Designer
     * >>> IMPORTANT!! <<<
     * DO NOT edit this method OR call it in your code!
     *
     * @noinspection ALL
     */
    private void $$$setupUI$$$() {
        createUIComponents();
        mainJPanel = new JPanel();
        mainJPanel.setLayout(new GridBagLayout());
        leftJPanel = new JPanel();
        leftJPanel.setLayout(new GridBagLayout());
        GridBagConstraints gbc;
        gbc = new GridBagConstraints();
        gbc.gridx = 0;
        gbc.gridy = 0;
        gbc.weightx = 1.0;
        gbc.weighty = 1.0;
        gbc.fill = GridBagConstraints.BOTH;
        mainJPanel.add(leftJPanel, gbc);
        btnSynchronise = new JButton();
        btnSynchronise.setText("Synchronise");
        gbc = new GridBagConstraints();
        gbc.gridx = 0;
        gbc.gridy = 2;
        gbc.weightx = 1.0;
        gbc.fill = GridBagConstraints.HORIZONTAL;
        leftJPanel.add(btnSynchronise, gbc);
        btnPreview = new JButton();
        btnPreview.setText("Preview");
        gbc = new GridBagConstraints();
        gbc.gridx = 0;
        gbc.gridy = 1;
        gbc.weightx = 1.0;
        gbc.fill = GridBagConstraints.HORIZONTAL;
        leftJPanel.add(btnPreview, gbc);
        gbc = new GridBagConstraints();
        gbc.gridx = 0;
        gbc.gridy = 0;
        gbc.weightx = 1.0;
        gbc.weighty = 1.0;
        gbc.fill = GridBagConstraints.BOTH;
        leftJPanel.add(JScrollPanePreview, gbc);
        JScrollPanePreview.setBorder(BorderFactory.createTitledBorder("XML File Preview"));
        rightJPanel = new JPanel();
        rightJPanel.setLayout(new GridBagLayout());
        gbc = new GridBagConstraints();
        gbc.gridx = 1;
        gbc.gridy = 0;
        gbc.weightx = 1.0;
        gbc.weighty = 1.0;
        gbc.fill = GridBagConstraints.BOTH;
        mainJPanel.add(rightJPanel, gbc);
        JScrollPaneReport = new JScrollPane();
        gbc = new GridBagConstraints();
        gbc.gridx = 0;
        gbc.gridy = 0;
        gbc.weightx = 1.0;
        gbc.weighty = 1.0;
        gbc.fill = GridBagConstraints.BOTH;
        rightJPanel.add(JScrollPaneReport, gbc);
        JScrollPaneReport.setBorder(BorderFactory.createTitledBorder("Synchronise report"));
    }

    /**
     * @noinspection ALL
     */
    public JComponent $$$getRootComponent$$$() {
        return mainJPanel;
    }
}


    package readDataPluginPackage;

import com.change_vision.jude.api.inf.project.ProjectAccessor;
import com.change_vision.jude.api.inf.project.ProjectAccessorFactory;
import com.change_vision.jude.api.inf.project.ProjectEvent;
import com.change_vision.jude.api.inf.project.ProjectEventListener;
import com.change_vision.jude.api.inf.ui.IPluginExtraTabView;
import com.change_vision.jude.api.inf.ui.ISelectionListener;

import javax.swing.*;
import java.awt.*;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;


public class ShowUserInterface extends JPanel implements IPluginExtraTabView, ProjectEventListener {

    public ShowUserInterface() {
        initComponents();
    }

    private void initComponents() {
        setLayout(new BorderLayout());
        add(createLabelPane());
        addProjectEventListener();
    }

    private void addProjectEventListener() {
        try {
            ProjectAccessor projectAccessor = ProjectAccessorFactory.getProjectAccessor();
            projectAccessor.addProjectEventListener(this);
        } catch (ClassNotFoundException e) {
            e.getMessage();
        }
    }

    private Container createLabelPane() {
        JLabel label = new JLabel("AuguSoft Synchronise");
        JScrollPane pane = new JScrollPane(label);


        Method privateMethod = null;
        Application app = null;
        Object o = null;
        JComponent jComponent = null;
        try {
            app = new Application();
            privateMethod = Application.class.getDeclaredMethod("$$$setupUI$$$");
            privateMethod.setAccessible(true);
            o = privateMethod.invoke(app);
            jComponent = app.$$$getRootComponent$$$();



        } catch (NoSuchMethodException e) {
            e.printStackTrace();
        } catch (IllegalAccessException e) {
            e.printStackTrace();
        } catch (InvocationTargetException e) {
            e.printStackTrace();
        }
        return jComponent;
    }





    @Override
    public void projectChanged(ProjectEvent e) {
    }

    @Override
    public void projectClosed(ProjectEvent e) {
    }

    @Override
    public void projectOpened(ProjectEvent e) {
    }

    @Override
    public void addSelectionListener(ISelectionListener listener) {
    }

    @Override
    public Component getComponent() {
        return this;
    }

    @Override
    public String getDescription() {
        return "Show AuguSoft Synchronise here";
    }

    @Override
    public String getTitle() {
        return "AuguSoft View";
    }

    public void activated() {

    }

    public void deactivated() {

    }
}

Answer 1

So, with doing nothing else but looking at you code, I noticed that in your createUIComponents method, you are shadowing the JScrollPanePreview property...

public class Application {

    //...    
    public JScrollPane JScrollPanePreview;
    //...    
    public Application() {..}

    private void createUIComponents() {
        if (btnPreviewClicked == true) {
            //...
            leftJPanel.remove(JScrollPanePreview);

            ShowXMLFileView showXMLFileView = new ShowXMLFileView();
            JScrollPane JScrollPanePreview = showXMLFileView.createLabelPane();
            //...
        } else {
            JScrollPanePreview = new JScrollPane();
        }

    }

This means that the next time you come to replace the JScrollPanePreview, you won't have the correct reference to remove it.

To my mind (and I don't have you full code base or intention), I'd simply replace the JScrollPanePreview view port (besides, I'm not sure how you can assign a Container to a JScrollPane anyway :P)

    private void createUIComponents() {
        if (btnPreviewClicked == true) {
            JScrollPanePreview.setViewportView(showXMLFileView.createLabelPane());
        } else {
            JScrollPanePreview = new JScrollPane();
        }

    }

Just as an observation ;)