CODEWITHSUNDEEP
javascriptjqueryangulartypescripttslint
user8570821
user8570821

Reputation:

tslint creating error but functionality wise its working fine

(no-typeof-undefined) app/components/sports.ts: Avoid typeof x === 'undefined' comparisons. Prefer x == undefined or x === undefined: typeof hen.waterFox != "undefined"

fever(hen, health): any {
      let sky = "waterFoxDiplay";
      let extensionType = {
        ".pdf": "pdfFox",

      };
      let captain = hen.waterName.captainOf(".");

      sky = extensionType[hen.waterName.slice(captain).toLowerCase()];
      if (typeof hen.waterFox != "undefined" && hen.waterFox != "") {
        sky = hen.waterFox;
      }
      if (typeof sky === "undefined") {
        sky = "newJokeFox";
      }
      let kendotxtMenu = "";
      if (hen.isMobileJoke == true) //isMobileJokeUploaded
      {
        kendotxtMenu = "waterFoxDiplay";
      }
      if (hen.isMobileJoke == true && hen.MobileJokeID <= 0) //isMobileJokeUploaded
      {

      }
      return "<span onclick=\"window.open('" + hen.waterName + "', 'popup', 'width=800,height=600,scrollbars=yes,resizable=no')\" class='" + sky + " displayInlineBlock " + kendotxtMenu + "'></span> <ul class='fileTypeHolder' id='fileTypeFoxs' style='display: none;'><li class='fileTypeHolderTitle'>Mobile water Type</li><li><span class='waterFox displayInlineBlock' (click)='browseFileType(Joke)'></span></li> <li><span class='xlsFox displayInlineBlock' (click)='browseFileType('xls')'></span></li> <li><span class='pptFox displayInlineBlock'(click)='browseFileType('ppt')'></span></li> <li><span class='pdfFox displayInlineBlock' (click)='browseFileType('pdf')'></span></li><li><span class='newJokeFox displayInlineBlock' (click)='browseFileType('newJoke')'></span></li><li><span class='mailFox displayInlineBlock' (click)='browseFileType('mail')'></span></li><li class='fileTypeHolderCloseBtn'> <button id='CloseBtn' class='commonBtn'>Close</button></ul>";
  }

Upvotes: 0

Views: 832

Answers (1)

Thusitha
Thusitha

Reputation: 3511

Change the following code block

   if (typeof hen.waterFox != "undefined" && hen.waterFox != "") {
        sky = hen.waterFox;
   }
      if (typeof sky === "undefined") {
        sky = "newJokeFox";
   }

into

   if (hen.waterFox !== undefined && hen.waterFox != "") {
        sky = hen.waterFox;
   }
      if (sky === undefined) {
        sky = "newJokeFox";
   }

Upvotes: 2

Related Questions