CODEWITHSUNDEEP
javaarraysstringmethods
Jason Aggarwal
Jason Aggarwal

Reputation: 35

Java: Remove an item from existing String Array

I've scoured a couple of the SOF threads but can't seem to find the answer I'm looking for. Most of them provide an answer with code that's beyond the scope of what I have learned thus far.

I've tried quite a few different things and can't get this to work the way I need it to.

The program is supposed to take the given array, read it, find the given toRemove item, and re-print the array without the toRemove item.

I believe my issue is within the removeFromArray method

public static void main(String[] args) 
{

    String[] test = {"this", "is", "the", "example", "of", "the", "call"};
    String[] result = removeFromArray(test, "the");
    System.out.println(Arrays.toString(result));
}

public static String[] removeFromArray(String[] arr, String toRemove)
{
    int newLength = 0;
    for(int i = 0; i < arr.length; i++)
    {    
        if(arr[i].contains(toRemove))
        {
            newLength++;
        }
    }
    String[] result = new String[arr.length-newLength];
    for(int i = 0; i < (result.length); i++)
    {
        if(arr[i].contains(toRemove))
        {

        }
        else
        {
            result[i] = arr[i];
        }
    }
    return result;
}

This is an assignment in my java class and we have not learned Lists (one of the answers I stumbled upon in my googling) yet so that is not an option for me.

As it is now, it should be outputting: [this, is, example, of, call]

Currently it is outputting: [this, is, null, example, of]

Any and all help will be much appreciated!

Upvotes: 3

Views: 7849

Answers (5)

Lakshmikant Deshpande
Lakshmikant Deshpande

Reputation: 844

The following code removes all occurrences of the provided string.

Note that I have added few lines for validate the input, because if we pass a null array to your program, it would fail. You should always validate the input in the code.

public static String[] removeFromArray(String[] arr, String toRemove) {

    // It is important to validate the input
    if (arr == null) {
        throw new IllegalArgumentException("Invalid input ! Please try again.");
    }

    // Count the occurrences of toRemove string.
    // Use Objects.equals in case array elements or toRemove is null.
    int counter = 0;
    for (int i = 0; i < arr.length; i++) {
        if (Objects.equals(arr[i], toRemove)) {
            counter++;
        }
    }

    // We don't need any extra space in the new array
    String[] result = new String[arr.length - counter]; 
    int resultIndex = 0; 

    for (int i = 0; i < arr.length; i++) {
        if (!Objects.equals(arr[i], toRemove)) {
            result[resultIndex] = arr[i];
            resultIndex++;
        }
    }

    return result;
}

Upvotes: 0

Maychell Fernandes
Maychell Fernandes

Reputation: 66

You can use Java Stream instead, it will give you the expected result and also your code will be clearer and really smaller.

See the method below I wrote that solves your problem.

public static String[] removeFromArray(String[] arr, String toRemove) {
    return Arrays.stream(arr)
      .filter(obj -> !obj.equals(toRemove))
      .toArray(String[]::new);
}

If you're unfamiliar with java Stream, please see the doc here

Upvotes: 0

jai
jai

Reputation: 118

Try this Java8 version

    List<String> test = Arrays.asList("this", "is", "the", "example", "of", "the", "call");

    test.stream()
        .filter(string -> !string.equals("the"))
        .collect(Collectors.toList())
        .forEach(System.out::println);

Upvotes: 0

Ahmad Khan
Ahmad Khan

Reputation: 2703

There's the error that @Eran pointed out in your code, which can solve your problem. But I'm going to discuss another approach.

For now, you're first iterating over the entire array to find the number of occurrences to remove, and then, you're iterating over the array to remove them. Why don't you just iterate over the array, just to remove them. (I know, your first loop is helping you to determine the size of the output array, but you don't need that if you use some List like ArrayList etc.)

List<String> resultList = new ArrayList<String>();
for(int i = 0; i < arr.length; i++)
{
    if(!arr[i].contains(toRemove))
    {
        resultList.add(arr[i]);
    }
}

And you can return the resultList, but if you really need to return an array, you can convert the resultList to an array like this:

String [] resultArray = resultList.toArray(new String[resultList.size()]);

And then return this array. See this approach live here on ideone.

Upvotes: 0

Eran
Eran

Reputation: 394146

You need 2 indices in the second loop, since you are iterating over two arrays (the input array and the output array) having different lengths.

Besides, newLength is a confusing name, since it doesn't contain the new length. It contains the difference between the input array length and the output array length. You can change its value to match its name.

int newLength = arr.length;
for(int i = 0; i < arr.length; i++)
{    
    if(arr[i].contains(toRemove))
    {
        newLength--;
    }
}
String[] result = new String[newLength];
int count = 0; // count tracks the current index of the output array
for(int i = 0; i < arr.length; i++) // i tracks the current index of the input array
{
    if(!arr[i].contains(toRemove)) {
        result[count] = arr[i]; 
        count++;
    }
}
return result;

Upvotes: 5

Related Questions