CODEWITHSUNDEEP
entity-framework-6
bitshift
bitshift

Reputation: 6852

Passing DbContext reference to another method from within a using statement bad practice?

I have a method that uses an EF 6 data model and is wrapped within a using statement. There are some additional and common steps that need to be done where Id rather not include them all in one method. The code below, while not the exact code Im using, seems to work. However, Im wondering if there is any "gotchyas" Im setting up related to EF-specific issues dealing with the DbContext itself. Especially in how everything must be translated to SQL?

The main goal is to do several operations on several entities before calling SaveChanges so that the implicit transactions covers all the changes rather than calling SaveChanges more than once leaving the option open for orphaned changes.

AppendFlagToOrder(ref DbContext tx, ref CustOrder o) {
    var oSettings = (from a in tx.OrderSettings where a.Type == o.OrderType select a).FirstOrDefault();
    if(!oSettings == null) {
        o.IsFlagged = oSettings.Flagged
    }
}


CheckOrderFlag(int OrderId) {       

     using (var ctx = new StoreDbCtx()) {
        CustOrder co = (from a in ctx.Orders where a.Id == OrderId select a).FirstOrDefault();
        AppendFlagToOrder(ctx,co);

        //-- continue with other operations
    }   
}

Upvotes: 0

Views: 203

Answers (1)

Daniel Lorenz
Daniel Lorenz

Reputation: 4336

You normally don't want to pass DbContext around like that as anyone would have the ability to call SaveChanges() on you at any point. The easiest thing to do would be to create an IStoreDbCtx interface that only has the DbSets on it you want exposed. Then you send that type through to the sub methods so they can't access SaveChanges() on you.

Upvotes: 1

Related Questions