CODEWITHSUNDEEP
phpmysqlpdo
Shoe
Shoe

Reputation: 76240

Problem connecting with PDO

It's the first time i'm using PDO just for testing purpose. But a strange error occurred and googling it, it seems to be weird.

Here's my database testing class

class db extends PDO
{
    # Our instance.
    private static $db = NULL;

    # Calling the connector.
    public static function connect()
    {
        if (self::$db === NULL)
        {
            $class = __CLASS__;
            self::$db = new $class();
        }
        return self::$db;
    }

    # Connector.
    public function __construct() 
    { 
        $dns = 'mysql:dbname='.reg::get('db-name').';host='.reg::get('db-host');
        self::$db = new PDO($dns, reg::get('db-username'), reg::get('db-password'));
        reg::delete('db-password');
    }

    # Quick reporting
    public function reportError($array)
    {
        if ($this->db != NULL) { echo 'Myself getting horny'; } // Just for testing, i'm not getting horny because of a mysql database connection!
    }

}

Then executing the following code:

$db = new db();
$row = $db->prepare('SELECT * FROM test WHERE id = :id')->execute(array('id' => 1));
echo $row['value'];

It shows me the following error:

Warning: PDO::prepare() [pdo.prepare]: SQLSTATE[00000]: No error: PDO constructor was not called in myfile.php on line 39

Considering line 39 as 

$row = $db->prepare('SELECT * FROM test WHERE id = :id')->execute(array('id' => 1));

Upvotes: 4

Views: 2845

Answers (4)

Alix Axel
Alix Axel

Reputation: 154553

You code is a mess, it's probably because you're so horny...

connect() method - why is it there?:

if ($db === NULL)

should be:

if (self::$db === NULL)

self::$db = new $class();

So, if $class == __CLASS__ == db, you are doing self::$db = new db();, doesn't seem right.

You can't use PDO to prepare an identifier, like a table or a column.

$db->prepare('SELECT * FROM :table WHERE id = :id')->execute(array('table' => 'test', 'id' => 1));

Should be:

$db->prepare('SELECT * FROM `test` WHERE id = :id')->execute(array('id' => 1));

Try this:

class db extends PDO
{
    private static $db = null;

    public static function singleton()
    {
        if (is_null(self::$db) === true)
        {
            self::$db = new PDO('mysql:dbname='.reg::get('db-name').';host='.reg::get('db-host'), reg::get('db-username'), reg::get('db-password'));
        }

        return self::$db;
    }
}

Like this:

$result = db::singleton()->prepare('SELECT * FROM `test` WHERE id = :id')->execute(array('id' => 1));

var_dump($result);

Upvotes: 5

brian_d
brian_d

Reputation: 11385

Your singleton pattern is all wrong. Your constructor should be private and you should use static instances of $db. Refer to this singleton example.

Upvotes: 1

Joe Phillips
Joe Phillips

Reputation: 51120

I'm not entirely sure if this is your answer, as it seems to be unrelated to the error message, but I do not think you can pass in a table name as a bound parameter. What happens if you put a hard-coded table name in the place of :table?

Upvotes: 2

Nanne
Nanne

Reputation: 64409

You have a static 'connect' constructor, that makes a db-object in (static), and returns it. But you also make a new db() yourself.

The prepare statement uses self::$db, so tries to call the static made variable. I'm not really sure how your code is supposed to work, combining some sort of singleton/static form with an object form.

But that seems to be the trouble

Upvotes: 1

Related Questions