UpdateView in Django shows blank forms instead of Database previous data

Question

I'm using UpdateView to edit data using forms.

After I click to edit the popup using modal is showing the forms with blank data! It doesn't retrieve the previous data that was in the Database. Anyone know what should I add?

I am stuck with this edit for about a week :(

If anyone has a clue I will be grateful! Thank you!

view.py-

from django.shortcuts import render_to_response
from django.shortcuts import get_object_or_404
from django.shortcuts import render, redirect
from django.template import RequestContext
from django.views.generic import TemplateView, UpdateView, DeleteView, CreateView
from DevOpsWeb.forms import HomeForm
from DevOpsWeb.models import serverlist
from django.core.urlresolvers import reverse_lazy
from simple_search import search_filter
from django.db.models import Q
class HomeView(TemplateView):

template_name = 'serverlist.html'


def get(self, request):
    form = HomeForm()
    query = request.GET.get("q")
    posts = serverlist.objects.all()

    if query:
        posts = serverlist.objects.filter(Q(ServerName__icontains=query) | Q(Owner__icontains=query) | Q(Project__icontains=query) | Q(Description__icontains=query) | Q(IP__icontains=query) | Q(ILO__icontains=query) | Q(Rack__icontains=query))
    else:
        posts = serverlist.objects.all()
    args = {'form' : form, 'posts' : posts}
    return render(request, self.template_name, args)

def post(self,request):
    form = HomeForm(request.POST)
    posts = serverlist.objects.all()



    if form.is_valid(): # Checks if validation of the forms passed
        post = form.save(commit=False)
        #if not form.cleaned_data['ServerName']:
        #post.servername = " "
        post.save()
        #text = form.cleaned_data['ServerName']
        form = HomeForm()
        return redirect('serverlist')
args = {'form': form,  'text' : text}
return render(request, self.template_name,args)


class PostDelete(DeleteView):
    model = serverlist
    success_url = reverse_lazy('serverlist')

class PostEdit(UpdateView):
    model = serverlist
    #post = serverlist.objetcs.get(server_id=server_id)
    fields = ['ServerName','Owner','Project','Description','IP','ILO','Rack','Status']
    success_url=reverse_lazy('serverlist')

urls.py -

from django.conf.urls import url, include
from DevOpsWeb.views import HomeView
from DevOpsWeb.views import PostDelete
from DevOpsWeb.views import PostEdit
from django.contrib import admin
admin.autodiscover()

urlpatterns = [
    # Examples:
    url(r'^$', HomeView.as_view(), name='serverlist'),

     url(r'^admin/doc/', include('django.contrib.admindocs.urls')),
     #DevOpsWeb:8000/Delete/
     url(r'^delete/(?P\d+)/$', PostDelete.as_view(), name="delete_post"),
     url(r'^django_popup_view_field/', include('django_popup_view_field.urls', namespace="django_popup_view_field")),
     url(r'^admin/', include(admin.site.urls)),
     #DevOpsWeb:8000/edit/
     url(r'^edit/(?P\d+)/$', PostEdit.as_view(), name="edit_post"),
]

forms.py -

from django import forms
from DevOpsWeb.models import serverlist


class HomeForm(forms.ModelForm):
    ServerName = forms.CharField(widget=forms.TextInput,max_length = 30,required=False)
    Owner = forms.CharField(max_length = 50,required=False)
    Project = forms.CharField(max_length = 30,required=False)
    Description = forms.CharField(max_length = 255,required=False)
    IP = forms.CharField(max_length = 30,required=False)
    ILO = forms.CharField(max_length = 30,required=False)
    Rack = forms.CharField(max_length = 30,required=False)
    Status = forms.CharField(max_length = 30,required=False)
    class Meta:
        model = serverlist
        fields = ('ServerName' ,'Owner','Project','Description','IP','ILO','Rack','Status',)

class AutoCompleteModelChoiceField(forms.ModelChoiceField):
    widget = forms.TextInput
def clean(self, value):
    value = super(AutoCompleteModelChoiceField, self).clean(value)
    return value


class serverForm(forms.ModelForm):
    hotel = AutoCompleteModelChoiceField(queryset=serverlist.objects.all())

index.html (The part with the edit button)-

            
  
    
                        
                                Edit Server {{ server.ServerName }} 
                                
                        
                                
                                         {% csrf_token %}
                                
                                                        {% for field in form %}
                                                                
                                                {{ field.errors }}
                                                                        

                                {{ field.html_name }} {{ field }} 

                                                {% if field.help_text %}
                                                {{ field.help_text|safe }}
                                                {% endif %}

                                                        


                                {% endfor %}
                
                
                      
                   
                                
                
                
            
                
        
                {% endfor %}

The posts and the edit button:

                {% for server in posts %}

        
          
            
            {{ server.ServerName }}
            {{ server.Owner }}
            {{ server.Project }}
            {{ server.Description }}
            {{ server.IP }}
            {{ server.ILO }}
            {{ server.Rack }}
            {{ server.Status }}

            

    
             
            
 


                        
                            
                                    
                                        
                                            Delete Confirmation
                                            
                                        
                                        
                                        {% csrf_token %}
                                            Are you sure you want to delete {{ server.ServerName }}?
                                                

                                            
                                                

                                        
                                    
                                    


                        
            




            
  
    
                        
                                Edit Server {{ server.ServerName }} 
                                
                        
                                
                                         {% csrf_token %}
                                
                                                        {% for field in form %}
                                                                
                                                {{ field.errors }}
                                                                        

                                {{ field.html_name }} {{ field }} 

                                                {% if field.help_text %}
                                                {{ field.help_text|safe }}
                                                {% endif %}

                                                        


                                {% endfor %}
                
                
                      
                   
                                
                
                
            
                
        
                {% endfor %}

dirkgroten · Accepted Answer

You're not initializing your form with the instance that you want to update:

form = HomeForm()

instead when you want to have a form filled with the data from an object:

form = HomeForm(instance=my_object_to_update)

Since you want to do this for every post you display in your HomeView, you need to initialize a different form for every post. In HomeView.get() and in HomeView.post() method, in addition to creating the empty HomeForm() that's used for creating a new serverlist:

for post in posts:
    forms[post.id] = HomeForm(instance=post)

And in your template render (assuming your loop {% for server in posts %})

{% with server.id as id %}
    {% with forms|get_by_key:id as edit_form %}
        
           ... display the form: your current code {% for field in edit_form %} etc...
         
    {% endwith %}
{% endwith %}

I'm using a custom template filter |get_by_key:variable to get the dict value by key when using a variable:

@register.filter(name='get_by_key')
def get_by_key(dictionnary, key):
"""Return element in dictionnary corresponding to `key`."""
    return dictionnary[key] if isinstance(dictionnary, dict) else ''

Since you have one template to create a new serverlist but also to show all the existing serverlist objects and uptdate them, you need both kinds of forms. So creating the forms dict above is in addition to having the creation form HomeForm(). Your context should have:

args = {
    'form': form,  # this is the serverlist creation form (empty)
    'forms': forms,  # these are all the forms for existing instances
    'posts': posts}

Also I don't see where in your PostEdit you specify your form_class, this is needed for an UpdateView to work.

UpdateView in Django shows blank forms instead of Database previous data

Answers (1)

Related Questions