CODEWITHSUNDEEP
androidgoogle-mapsgoogle-maps-markers
Michael
Michael

Reputation: 31

Android Google Map view returns error when onTap() is used - Alertdialog is supposed to be displayed

I currently have modified 'Google Map View' code (found below) but when the map loads and you click on the item on the map it returns an error.

I believe it has something to do with the null value for mContext but I'm not sure, I would really appreciate it if anyone could help me out with this: 

protected boolean onTap(int index) {
OverlayItem item = mOverlays.get(index);
Context mContext = null;
AlertDialog.Builder dialog = new AlertDialog.Builder(mContext);

My Map class:

package testing.map;

import java.util.List;

import com.google.android.maps.GeoPoint;
import com.google.android.maps.MapActivity;
import com.google.android.maps.MapView;
import com.google.android.maps.Overlay;
import com.google.android.maps.OverlayItem;

import android.content.Context;
import android.graphics.drawable.Drawable;
import android.os.Bundle;

public class Mapview extends MapActivity {
    /** Called when the activity is first created. */

protected boolean isRouteDisplayed(){
    return false;
}
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.mapview);

        MapView mapView = (MapView) findViewById(R.id.mapview);
        mapView.setBuiltInZoomControls(true);

        List<Overlay> mapOverlays = mapView.getOverlays();
        Drawable drawable = this.getResources().getDrawable(R.drawable.jd_sports_logo);
        HelloItemizedOverlay itemizedoverlay = new HelloItemizedOverlay(drawable);

        //Declared longitude/latitude as doubles as GeoPoint only uses 'int' - converted to microdegrees
        double latitude = 51.545538;
        double longitude = -0.477247;
        GeoPoint point = new GeoPoint((int)(latitude * 1e6), (int)(longitude * 1e6));

        OverlayItem overlayitem = new OverlayItem(point, "Hola, Mundo!", "I'm in Mexico City!");

        itemizedoverlay.addOverlay(overlayitem);
        mapOverlays.add(itemizedoverlay);
    }

    }

My HelloItemizedOverlay class:

package testing.map;

import java.util.ArrayList;
import android.graphics.drawable.Drawable;
import android.app.AlertDialog;
import android.content.Context;
import com.google.android.maps.ItemizedOverlay;
import com.google.android.maps.OverlayItem;

public class HelloItemizedOverlay extends ItemizedOverlay {

    private ArrayList<OverlayItem> mOverlays = new ArrayList<OverlayItem>();

    public HelloItemizedOverlay(Drawable defaultMarker) {
        super(boundCenterBottom(defaultMarker));

    }
    public void addOverlay(OverlayItem overlay) {

        mOverlays.add(overlay);
        populate();
    }
    public HelloItemizedOverlay(Drawable defaultMarker, Context context) {
          super(defaultMarker);
          Context mContext = context;
        }

    @Override
    protected OverlayItem createItem(int i) {
        // TODO Auto-generated method stub
        return mOverlays.get(i);
    }

    @Override
    public int size() {
        // TODO Auto-generated method stub
        return mOverlays.size();
    }

    @Override
    protected boolean onTap(int index) {
      OverlayItem item = mOverlays.get(index);
      Context mContext = null;
      AlertDialog.Builder dialog = new AlertDialog.Builder(mContext);
      dialog.setTitle(item.getTitle());
      dialog.setMessage(item.getSnippet());
      dialog.show();
      return true;
    }

}

Upvotes: 3

Views: 3974

Answers (4)

Jol Blazey
Jol Blazey

Reputation: 11

I also found that the HelloGoogleMaps tutorial code failed with a npe when you tap the marker.

If you pass this (from an instance that extends MapActivity) the dialog shows.

  HelloItemizedOverlay itemizedoverlay = new HelloItemizedOverlay(drawable, this);

Constructor required:

public HelloItemizedOverlay(Drawable defaultMarker, Context context) {
          super(defaultMarker);
          mContext = context;
    }

Upvotes: 1

Anand
Anand

Reputation: 1325

you can pass context like this, here is the pseudo code:

  HelloItemizedOverlay itemizedoverlay = new HelloItemizedOverlay(this,drawable);

Upvotes: 0

user484691
user484691

Reputation: 381

You are missing the Context in the main class.

Add this :

HelloItemizedOverlay itemizedoverlay = new HelloItemizedOverlay(drawable, mContext);
where mContext = this;

instead of this:

HelloItemizedOverlay itemizedoverlay = new HelloItemizedOverlay(drawable);

Upvotes: 5

user1106725
user1106725

Reputation: 11

Change two places:

1.

HelloItemizedOverlay itemizedoverlay = new HelloItemizedOverlay(drawable, this);

2.

public HelloItemizedOverlay(Drawable defaultMarker, Context context) {
    super(boundCenterBottom(defaultMarker));
    mContext = context;
}

Upvotes: 1

Related Questions