J.Emrys
J.Emrys

Reputation: 39

That page number is less than 1 Django

I have read almost all the thread related to a similar error message and none of them offered a solution to my problem. I a story and for each story there are chapters. The idea is that there will be a chapter per page but I keep getting the same error message "EmptyPage at /story/1/page/1/" when I try pagination.

I have multiple chapters for each story and I still get page number is less than 1.

views.py

def post(request, id_story, page=1):
    story = Story.objects.get(id=id_story)
    chapters = story.chapter_set.all()
    paginator = Paginator(chapters, 1)
    try:
        chapters = paginator.page(page)
    except PageNotAnInteger:
        chapters = paginator.page(1)
    except EmptyPage:
        chapters = paginator.page(paginator.num_pages)
    return render(request, 'single.html', {'story': story, 'chapters': chapters})

models.py

class Story(models.Model):
    Lang =(
        ('LA', '-LANGUAGE-'),
        ('Ar', 'ARABIC'),
        ('Ot', 'OTHER')
    )
    title = models.CharField(max_length=250, null=False)
    author = models.ForeignKey(User, on_delete=models.CASCADE)
    summary = models.TextField(max_length=1000, null= False)
    pub_date = models.DateField(auto_now_add=True, blank=False, null=False)
    update_time = models.DateField(null=True)
    has_chapter = models.BooleanField(default=False, editable=False)
    lang = models.CharField(choices=Lang, default=Lang[0], max_length=3)
    story_cover = models.FileField()

    def __str__(self):
        return self.title + " - " + self.author.username


class Chapter(models.Model):
    story = models.ForeignKey(Story, on_delete=models.CASCADE)
    chapter_number = models.IntegerField(editable=False, default=1)
    title = models.CharField(max_length=250, null=True)
    chapter = models.TextField()

    def save(self, *args, **kwargs):
        number = Chapter.objects.filter(story=self.story).count()
        self.chapter_number = number + 1
        story = self.story
        if not story.has_chapter:
            story.has_chapter = True
            story.save()
        super(Chapter, self).save(*args,**kwargs)

urls.py

url(r'^story/(?P<id_story>[0-9]+)/page/(?P<page>[0-9]+)/$', views.post, name="post"),

and finally the template

<span class="image featured"><img src="{% static 'images/yogo.jpg'%}" alt=""/></span>
         {% for chapter in chapters %}
                 {% autoescape off%}
                                <h6>{{chapter.title}}</h6>
                               {{chapter.chapter}}
                                {% endautoescape %}
                    {% endfor %}
        <footer>
            <ul class="stats">
                <li><a href="#" class="icon fa-heart">28</a></li>
                <li><a href="#" class="icon fa-comment">128</a></li>
            </ul>
        </footer>
         {% if chapters.has_other_pages %}
        <ul class="actions pagination">
            {% if chapters.has_previous %}
            <li><a href="?page={{ chapters.previous_page_number }}" class=" button big previous">Previous Page</a></li>
            {% else %}
            <li><a href="?page={{ chapters.previous_page_number }}" class="disabled button big previous">Previous Page</a></li>
            {%endif%}
            {% if chapters.has_next %}
            <li><a href="?page={{ chapters.next_page_number }}" class="button big next">Next Page</a></li>
            {%else%}
            <li><a href="?page={{ chapters.next_page_number }}" class="button big next">Next Page</a></li>
            {%endif%}

        </ul>
         {%endif%}

Upvotes: 4

Views: 4246

Answers (1)

YGouddi
YGouddi

Reputation: 361

The problem you're facing lies in the both {%else%}s you're doing in the pagination.

       {% if chapters.has_previous %}
            <li><a href="?page={{ chapters.previous_page_number }}" class=" button big previous">Previous Page</a></li>
      {% else %}
            <li><a href="?page={{ chapters.previous_page_number }}" class="disabled button big previous">Previous Page</a></li>
      {%endif%}
      {% if chapters.has_next %}
            <li><a href="?page={{ chapters.next_page_number }}" class="button big next">Next Page</a></li>
      {%else%}
            <li><a href="?page={{ chapters.next_page_number }}" class="button big next">Next Page</a></li>
      {%endif%}

When django tries to render your page and it's page = 1 reaching the first else statement it'll find that page will be a 0 which is not correct, the same thing will be for when it doesn't have a next page at the else for the next instruction. As a solution it should be like this :

 {% if chapters.has_previous %}
            <li><a href="?page={{ chapters.previous_page_number }}" class=" button big previous">Previous Page</a></li>
      {% else %}
            <li><a href="#" class="disabled button big previous">Previous Page</a></li>
      {%endif%}
      {% if chapters.has_next %}
            <li><a href="?page={{ chapters.next_page_number }}" class="button big next">Next Page</a></li>
      {%else%}
            <li><a href="#" class="button big next">Next Page</a></li>
      {%endif%}

Upvotes: 8

Related Questions