CODEWITHSUNDEEP
go
Yanis Bendahmane
Yanis Bendahmane

Reputation: 57

Golang Calculator -- Can't divide by 0 error


I'm actually in a bit of a trouble...
I have a calculator, but when I want to divide nubers with them, I have a panic err saying that you can't divide by 0.
Well, I know that in maths we can't divide by 0, but I don't put 0 in my ints. Any idea of the problem ?
Here is the code :

package main

import (
    "fmt"
    "os"
    "strconv"
)

func mult(nums ...int)  {
    result := 0
    total := 1
    for _, num := range nums {
        result = total * num
        total = result
    }
    fmt.Println(result)
}

func add(nums ...int){
    result := 0
    total := 0
    for _, num := range nums {
        result = total + num
        total = result
    }
    fmt.Println(result)
}

func sub(nums ...int){
    result := 0
    total := 0
    for _, num := range nums {
        result = num - total
        total = result
    }
    fmt.Println(result)
}

func div(nums ...int){
    result := 1
    total := 1
    for _, num := range nums {
        result = num / total
        total = result
    }
    fmt.Println(result)
}

func main() {
    var d [] int
    var args= os.Args[1:]
    nums := make([]int, len(args))
    for i := 0; i < len(args); i++ {
        nums[i], _ = strconv.Atoi(args[i]);
        strconv.Atoi(args[i])
        d = append(d, nums[i])
    }
    num := d
    if os.Args[1] == "*"{
        mult(num...)
    } else if os.Args[1] == "+"{
        add(num...)
    } else if os.Args[1] == "-"{
        sub(num...)
    } else if os.Args[1] == "/"{
        div(num...)
    } else {
        fmt.Println("Well well well, you didn't entered a right operand ! Try with +, -, /, or * between double quotes")
    }
}

The command I want to run this go code is :

go run calc.exe / 3 2 [Infinite args,...]

Upvotes: 0

Views: 6189

Answers (1)

dvaltrick
dvaltrick

Reputation: 122

If your first parameter will always be a operator select, you can do something like that in your main func, you have a two problems in your main, you are ignoring the convertion error of a string to int and then this index of your array are setted with 0, and you are defining the array larger than you need because your first parameter it's not a number to your div func 

nums := make([]int, len(args)-1)
for i := 0; i < len(args); i++ {
    ret, errAtoi := strconv.Atoi(args[i])
    if errAtoi != nil {
        fmt.Println(errAtoi.Error())
    } else {
        nums[i-1] = ret
        d = append(d, nums[i-1])
    }
}

Upvotes: 1

Related Questions