CODEWITHSUNDEEP
reactjsreact-router
crazyCoder
crazyCoder

Reputation: 339

How to use onClick event on Link: ReactJS?

In React router, I have to and onClick attributes as shown below

<li key={i}><Link to="/about" onClick={() => props.selectName(name)}>{name}</Link></li>

state = {
    selectedName: ''
};

selectName = (name) => {
   setTimeout(function(){this.setState({selectedName:name});}.bind(this),1000);
   // this.setState({selectedName: name});
}

When I give timeout insided function called on click, its navigating to new page and after sometime state is getting updated resulting in displaying previous name until state is updated with new name.

Is there a way where it will navigate to the new route only after the code in onClick function gets executed.

You can get the entire code [here].(https://github.com/pushkalb123/basic-react-router/blob/master/src/App.js)

Upvotes: 17

Views: 34321

Answers (2)

Mayank Shukla
Mayank Shukla

Reputation: 104539

One possible way is, Instead of using Link, use history.push to change the route dynamically. To achieve that remove the Link component and define the onClick event on li. Now first perform all the task inside onClick function and at the end use history.push to change the route means to navigate on other page.

In your case change the router inside setState callback function to ensure that it will happen only after state change.

Write it like this:

<li key={i} onClick={() => props.selectName(name)}> {name} </li>

selectName = (name) => {
    this.setState({ selectedName:name }, () => {
        this.props.history.push('about');
    });
}

Check this answers for:

When to use setState callback

How to navigate dynamically using react router dom

Upvotes: 16

Rohan Varma
Rohan Varma

Reputation: 1205

Alternatively, I would recommend using URL Params in order to capture the name of the person that the about page is about. Thus, instead of the url being /about and the name being behind the scenes, it would be /about/tom or /about/pushkal. The way that you do this is by defining params in the URL router as such in your index.js:

<Route path="/about/:name" component={AboutPage}>

Now, when you link to the about page, you would do it as such:

<Link to={"/about/" + name}>{name}</Link>

Now, in your AboutPage component, you can access the name param as a prop in this.props.params.name. You can look at more examples here.

This method is a bit different than your current approach but I suspect it will lead to easier design later on

Upvotes: 3

Related Questions