CODEWITHSUNDEEP
androiddatabasesqliteconnection
jim.huang
jim.huang

Reputation: 1052

When to close db connection on android? Every time after your operation finished or after your app exit

I have an android application that access local sqlite3 db frequently, for performance consideration so i always keep the connection open. But one of my friends recommended me to open/close the connection every operation.

1) What's your guys opinion on these two methods ? cons/pros. 2) I did some testing and find the DB connection doesn't have too much perf overhead. Does the performance overhead of DB connection varies on the size of the DB ?

Upvotes: 46

Views: 16140

Answers (4)

Seagull
Seagull

Reputation: 1133

The documentation says the connection can be open as long as you need it. And can be closed in onDestroy() method. Documentation link

Persisting Database Connection:

Since getWritableDatabase() and getReadableDatabase() are expensive to call when the database is closed, you should leave your database connection open for as long as you possibly need to access it. Typically, it is optimal to close the database in the onDestroy() of the calling Activity.

    @Override
    protected void onDestroy() {
        mDbHelper.close();
        super.onDestroy();
    }

Upvotes: 3

stdout
stdout

Reputation: 2651

As an addition, opening & closing a connection so frequently might possibly cause you to experience notorious SQLite exceptions, if you access db from multiple threads.

See, if you access db from multiple threads even over a single connection and since those operation are not atomic, then you may try to update db which was closed just before by another thread.

Upvotes: 2

David Sykes
David Sykes

Reputation: 49832

If you are using an in memory database then your data will be discarded when you close the connection.

A bit of an edge case perhaps, but it just caught me out.

Upvotes: 6

dbm
dbm

Reputation: 10485

I don't know of any performance penalties in frequent closing/opening of the database (regardless of its size). I think the answer to this question also depends on what type of application is accessing the database.

Do you "re-query" the database a lot?
Then it seems rectified to keep it open.

Do you fetch different data each time you fetch something?
Again, it seems reasonable to leave it open (as you won't gain in caching the data instead).

Are there any other applications accessing the same database?
If there is a risk for concurrency or blocking issues, it might be wise to close the database after finished reading/writing from/to it.

Generally I would say that you might gain more in caching data than in leaving the database open (contra closing it) when optimizing for performance.

Upvotes: 33

Related Questions