CODEWITHSUNDEEP
asp.net-mvc-3razor
Ruud van Falier
Ruud van Falier

Reputation: 8877

MVC Razor dynamic model, 'object' does not contain definition for 'PropertyName'

Using MVC 3 with Razor view engine. I have this View:

@model dynamic
@{
    var products = (List<ListItemBaseModel>)Model.Products;
    var threshold = (int)(Model.Threshold ?? 1);
    var id = Guid.NewGuid().ToString();
}

It is called from another view using this code:

@Html.Partial("PartialViewName", new { Products = Model, Threshold = 5 })

In both Views, when I debug them and watch Model, it seems to contain the correct object.
When I execute the code I get an error on the var products = line saying:

'object' does not contain a definition for 'Products'

Why do I see this error?
When I watch the Model object in debugging mode it looks all right (having 2 properties: Products and Threshold)

Upvotes: 107

Views: 87984

Answers (8)

Lucas
Lucas

Reputation: 17424

I just tried this (dynamic view model in CSHTML) and got the same error as your when using an anonymous class, but it worked fine if I created a named class. I searched but haven't seen this documented anywhere.

// error
return View(new { Foo = 1, Bar = "test" });

// worked
return View(new TestClass { Foo = 1, Bar = "test" });

David Ebbo clarified that you can't pass an anonymous type into a dynamically-typed view because the anonymous types are compiled as internal. Since the CSHTML view is compiled into a separate assembly, it can't access the anonymous type's properties. Due to this forum post, David Ebbo clarified on (Dec 22 2011) that MVC 3 now has direct support for dynamic.

Upvotes: 153

Gerade Geldenhuys
Gerade Geldenhuys

Reputation: 139

I worked around this issue by using a Dictionary.

 @Html.Partial("_Partial", new Dictionary<string, string> { { "Key1", "Val1" }, { "Key2", "Val2" }, { "Key3", "Val3" } });

Upvotes: 0

JamesG
JamesG

Reputation: 532

Instead of using the dynamic Model type within the partial view.

You can call the anonymous object attributes using @ViewData.Eval("foo") instead of @Model.foo.

Then you can remove @Model dynamic from the view.

I came across this issue recently when passing some attributes between views for the Facebook Social Comments Integration. Example code:

Html.RenderPartial(@"Layouts/Partials/_Comments", new {currentUrl = Model.CurrentPage.GetAbsoluteUrl(), commentCount = 5 });

Then in my view I just had this div:

<div class="fb-comments" data-href="@ViewData.Eval("currentUrl")" data-numposts="@ViewData.Eval("commentCount")" data-width="100%"></div>

Upvotes: 9

DATEx2
DATEx2

Reputation: 3513

On .NET 4.0 Anonymous types can easily be converted to ExpandoObjects and thus all the problems are fixed with the overhead of the conversion itself. Check out here

Upvotes: 41

the_joric
the_joric

Reputation: 12226

To use dynamic type you need to reference Microsoft.CSharp assembly

Upvotes: -6

joshcomley
joshcomley

Reputation: 28808

This has nothing to do with anonymous types having internal properties

It is perfectly possible to pass anonymous types from a view to a partial view

I encountered the same problem today and it was nothing (directly) to do with the problem of passing anonymous types and their inherent internal properties.

As such, in relation to the OPs question, the answer by @Lucas is irrelevant - even though the workaround will work.

In the OPs question, an anonymous type is being passed from a view in assembly X to a partial in assembly X, therefore the problem that David Ebbo outlined of the properties being internal for anonymous types is of no consequence; the types compiled for the view, the partial and the anonymous type are all contained in the same assembly.

So what is causing the sudden failure to pass an anonymous type from a view to a partial?

At least in my situation, I discovered that it was due to having another view in the SAME FOLDER that specifies a model type that cannot be resolved. Views get compiled at runtime, and so it would make sense as a failure at runtime to compile the views would also mean a failure to compile the dynamic types and the partial would simply receive an object. It's not immediately obvious what is going on, but in the OPs specific example (and mine) this is more than likely the cause of the problem.

It is interesting to note that if the model type is correct but another part of the view doesn't compile then anonymous types are not affected in the same way. This must be down to how Razor breaks up the dynamic compilation of the component parts of the view.

Once you correct the offending view, either rebuild the whole solution or clean and rebuild the project before checking to see if it's fixed.

To ensure you are not caught out by this again you can enable compile time compilation of your Razor views by adding this to your csproj file:

<PropertyGroup>
    <MvcBuildViews>true</MvcBuildViews>
</PropertyGroup>

Upvotes: 30

goran
goran

Reputation: 1

i am not sure that you are getting this error because you are not implementing the work-around. i got the same error in a partial view. the solution was just to clean the build and rebuild it. if the syntax is correct, the code should work, but the razor engine may not be updating the code changes properly.

Upvotes: 0

Segev -CJ- Shmueli
Segev -CJ- Shmueli

Reputation: 1621

Add the following class anywhere in your solution (use System namespace, so its ready to use without having to add any references) - 

    namespace System
    {
        public static class ExpandoHelper
        {
            public static ExpandoObject ToExpando(this object anonymousObject)
            {
                IDictionary<string, object> anonymousDictionary = HtmlHelper.AnonymousObjectToHtmlAttributes(anonymousObject);
                IDictionary<string, object> expando = new ExpandoObject();
                foreach (var item in anonymousDictionary)
                    expando.Add(item);
                return (ExpandoObject)expando;
            }

        }
    }

When you send the model to the view, convert it to Expando : 

    return View(new {x=4, y=6}.ToExpando());

Upvotes: 10

Related Questions