CODEWITHSUNDEEP
node.jsexpressmulter
MUHAMMAD Siyab
MUHAMMAD Siyab

Reputation: 446

Multer: fileFilter not working

I'm using multer to upload files. everything is goung fine but fileFilter is not working. I've no idea where i'm going wrong.

routes.js

var multer = require('multer');
// Multer diskStorage setting
var storage = multer.diskStorage({
  destination: function (req, file, callback) {
    callback(null, './uploads/');
  },
  filFilter: function (req, file, cb) {
    var typeArray = file.mimetype.split('/');
    var fileType = typeArray[1];
    if (fileType == 'jpg' || fileType == 'png') {
      cb(null, true);
    } else {
      cb(null, false)
    }
  },
  filename: function (req, file, callback) {
    callback(null, file.fieldname + '_' + Date.now() + '.jpg');
  }
});

var upload = multer({ storage: storage });
router.post('/add', upload.single('photo'), function(req, res){

    console.log('uploaded');
}

Multer also uploads files other than allowed. Any idea?

Upvotes: 8

Views: 8351

Answers (3)

iLiA
iLiA

Reputation: 3153

const storage = multer.diskStorage({
    destination: function (req, file, callback) {
        callback(null, './uploads/');
    },
    fileFilter: function (req, file, cb) {
        const extension = path.extname(file.originalname).toLowerCase();
        const mimetyp = file.mimetype;
        if (
            extension !== '.jpg' ||
            extension !== '.jpeg' ||
            extension !== '.png' ||
            mimetyp !== 'image/png' ||
            mimetyp !== 'image/jpg' ||
            mimetyp !== 'image/jpeg'
        ) {
            cb('error message', true);
        }
    },
    filename: function (req, file, callback) {
        callback(null, file.fieldname + '_' + Date.now() + '.jpg');
    },
});

const upload = multer({ storage: storage });
router.post('/add', upload.single('photo'), function (req, res) {
    console.log('uploaded');
});

i think this will help

Upvotes: 7

keeri
keeri

Reputation: 814

fileFilter must be defined in multer's options object rather than diskStorage

const uploadFilter = function(req, file, cb) {
    // filter rules here
}

const upload = multer({
    storage: storage,
    fileFilter: uploadFilter,
});

Upvotes: 9

Dan Bachar
Dan Bachar

Reputation: 149

You have a typo at your fileFilter; you've named it filFilter. Could you change your code to the following and tell us if it worked out?

var multer = require('multer');
// Multer diskStorage setting
var storage = multer.diskStorage({
  destination: function (req, file, callback) {
    callback(null, './uploads/');
  },
  fileFilter: function (req, file, cb) {
    var typeArray = file.mimetype.split('/');
    var fileType = typeArray[1];
    if (fileType == 'jpg' || fileType == 'png') {
      cb(null, true);
    } else {
      cb(null, false)
    }
  },
  filename: function (req, file, callback) {
    callback(null, file.fieldname + '_' + Date.now() + '.jpg');
  }
});

var upload = multer({ storage: storage });
router.post('/add', upload.single('photo'), function(req, res){

    console.log('uploaded');
}

Upvotes: 3

Related Questions