CODEWITHSUNDEEP
c#wpfmessagebox
sosohanBoX
sosohanBoX

Reputation: 13

C# The exit message box pops up twice. I want to generate an event once.

bool ClosedFormMenu = false;

    private void Cancel_btn_Click(object sender, EventArgs e)
    {
        DialogResult dialog = MessageBox.Show("Do you really want to close the program?", "program close", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
        if(dialog == DialogResult.Yes)
        {
            ClosedFormMenu = true;
            Application.Exit();
        }
    }

    private void Form_closing(object sender, FormClosingEventArgs e)
    {
        DialogResult dialog = MessageBox.Show("Do you really want to close the program?", "program close", MessageBoxButtons.YesNo, MessageBoxIcon.Question);

        if(!ClosedFormMenu)
        {
            if (dialog == DialogResult.Yes)
            {
                Application.Exit();
            }
            else if (dialog == DialogResult.No)
            {
                e.Cancel = true;
                return;
            }
        }

    }

Press the X or Cancel button to display the exit message. Press 'Yes' on the message and it will appear again. I want to eliminate this phenomenon. I would like to implement the program so that it will exit completely if I click cancel button or X button. Answer Thanks in advance. Thank you.

Upvotes: 1

Views: 1559

Answers (2)

Oystein
Oystein

Reputation: 1322

Calling Application.Exit() from the button handler also calls Form_closing(). Having the dialog box in both the button handler and Form_closing() makes the question appear twice. Try this:

private void Cancel_btn_Click(object sender, EventArgs e)
{
    Application.Exit();
}

private void Form_closing(object sender, FormClosingEventArgs e)
{
    DialogResult dialog = MessageBox.Show("Do you really want to close the program?", "program close", MessageBoxButtons.YesNo, MessageBoxIcon.Question);

    if (dialog == DialogResult.Yes)
    {
        e.Cancel = false;
    }
    else
    {
        e.Cancel = true;
    }

}

Upvotes: 1

KampfFussel
KampfFussel

Reputation: 137

As soon as you call Application.Exit(), the event method Form_closing() will be called. This is why your MessageBox appears twice.

You call it in the Cancel method, exit out of the application, the application calls Form_Closing() and the MessageBox appears again.

You should only call

Application.Exit();

in your Cancel_btn_Click Method.

You can reduce your code to the following:

private void Cancel_btn_Click(object sender, EventArgs e)
{
    Application.Exit();
}

private void Form_closing(object sender, FormClosingEventArgs e)
{
    DialogResult dialog = MessageBox.Show("Do you really want to close the program?", "program close", MessageBoxButtons.YesNo, MessageBoxIcon.Question);

    if (dialog == DialogResult.No)
        e.Cancel = true;
    // TODO: Add 'else' if you want to call a cleanup
    // method or do something before the application closes.
}

Why is 'return' missing in Form_closing()?

'return' is missing, because this is a method with the return type 'void'. It is not expected to 'return' anything and since we do not need to exit out of the method prematurely, we do not need it.

Why is 'Application.Exit()' missing in Form_closing()?

The application has already received the command to exit. This is why it is closing the form. Therefor, we do not need it here.

Upvotes: 3

Related Questions